Re: [External] : Re: [jpackage] Changes to icon handling between Java 17 and Java 21 on Windows

2024-11-07 Thread Daniel Peintner
Hi Alexey, However, I find it suspicious that other app icons are OK on your > screenshots and only an icon of the package-created app is blank. If you > have a reproducible example, please file a bug! > I have tried the *same* msi installer on 3 windows machines and only one shows no app icon. H

Re: [External] : Re: [jpackage] Changes to icon handling between Java 17 and Java 21 on Windows

2024-11-07 Thread Alexey Semenyuk
Hi Daniel, Given your description of the issue with blank icons as specific to some deployments only, it may be a Windows issue. "missing" .ico files in app image should not be the cause. However, I find it suspicious that other app icons are OK on your screenshots and only an icon of the pac

Re: [jpackage] Changes to icon handling between Java 17 and Java 21 on Windows

2024-11-07 Thread Daniel Peintner
Hi Alexey, all, Thank you very much for your reply and the pointers you provided. Honestly I don't mind whether the ico file is part of the exe or not. It should just work as expected. Having said that, we are seeing issues that in some cases it doesn't seem to work (i.e., not showing any icon).

Re: [jpackage] Changes to icon handling between Java 17 and Java 21 on Windows

2024-11-06 Thread Alexey Semenyuk
Hi Daniel, On Windows, the jpackage embeds icons in app launcher executables and there is no reason to keep these .ico files in the app image. In [1], it was reasonably requested not to include app launcher icons in the app image on Windows, and that was fulfilled. [1] https://bugs.openjdk.o