Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v4]

2022-07-18 Thread Ioi Lam
On Mon, 18 Jul 2022 03:41:45 GMT, David Holmes wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed tier4 failure with hotspot_appcds_dynamic testing > > Looks good! > > Thanks. Thanks @dholmes-ora, @calvinccheung, @

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v4]

2022-07-18 Thread Calvin Cheung
On Mon, 18 Jul 2022 19:01:28 GMT, Ioi Lam wrote: >> Since the impact of this bug can be big, and the fix is simple and low risk >> (just avoids doing optimizations), I'd like to put this into JDK 19 before >> RDP2 (Jul 21). >> >> CDS cannot handle Lambda proxy classes that are generated in the

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v4]

2022-07-18 Thread Ioi Lam
> Since the impact of this bug can be big, and the fix is simple and low risk > (just avoids doing optimizations), I'd like to put this into JDK 19 before > RDP2 (Jul 21). > > CDS cannot handle Lambda proxy classes that are generated in the > useImplMethodHandle mode. This could happen with cla

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v2]

2022-07-18 Thread Ioi Lam
On Mon, 18 Jul 2022 17:56:23 GMT, Mandy Chung wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed typo > > test/hotspot/jtreg/runtime/cds/appcds/test-classes/pkg1/BaseWithProtectedMethod.java > line 29: > >> 27: pub

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v3]

2022-07-18 Thread Ioi Lam
> Since the impact of this bug can be big, and the fix is simple and low risk > (just avoids doing optimizations), I'd like to put this into JDK 19 before > RDP2 (Jul 21). > > CDS cannot handle Lambda proxy classes that are generated in the > useImplMethodHandle mode. This could happen with cla

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v2]

2022-07-18 Thread Ioi Lam
On Mon, 18 Jul 2022 16:15:26 GMT, Calvin Cheung wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed typo > > test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/DynamicLambdaWithUseImplMethodHandle.java > line 41: >

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v2]

2022-07-18 Thread Mandy Chung
On Mon, 18 Jul 2022 04:14:03 GMT, Ioi Lam wrote: >> Since the impact of this bug can be big, and the fix is simple and low risk >> (just avoids doing optimizations), I'd like to put this into JDK 19 before >> RDP2 (Jul 21). >> >> CDS cannot handle Lambda proxy classes that are generated in the

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v2]

2022-07-18 Thread Calvin Cheung
On Mon, 18 Jul 2022 04:14:03 GMT, Ioi Lam wrote: >> Since the impact of this bug can be big, and the fix is simple and low risk >> (just avoids doing optimizations), I'd like to put this into JDK 19 before >> RDP2 (Jul 21). >> >> CDS cannot handle Lambda proxy classes that are generated in the

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle [v2]

2022-07-17 Thread Ioi Lam
> Since the impact of this bug can be big, and the fix is simple and low risk > (just avoids doing optimizations), I'd like to put this into JDK 19 before > RDP2 (Jul 21). > > CDS cannot handle Lambda proxy classes that are generated in the > useImplMethodHandle mode. This could happen with cla

Re: [jdk19] RFR: 8290417: CDS cannot archive lamda proxy with useImplMethodHandle

2022-07-17 Thread David Holmes
On Mon, 18 Jul 2022 03:15:02 GMT, Ioi Lam wrote: > Since the impact of this bug can be big, and the fix is simple and low risk > (just avoids doing optimizations), I'd like to put this into JDK 19 before > RDP2 (Jul 21). > > CDS cannot handle Lambda proxy classes that are generated in the > u