Re: RFR: JDK-8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing

2024-04-10 Thread Matthias Baesken
On Tue, 9 Apr 2024 17:26:46 GMT, Alan Bateman wrote: > If we expand the tracing then I think it should be consistent with the > existing tracing. I just added some tracing calls where I missed them. Do you think I should do some more adjustments ? Btw. is the `GetApplicationHomeFromDll` (

Re: RFR: JDK-8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing

2024-04-09 Thread Alan Bateman
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote: > We have already good JLI tracing capabilities. But GetApplicationHome and > GetApplicationHomeFromDll lack some tracing and should be enhanced. This looks very ad hoc. Not opposed to expanding the set of trace messages when this env va

Re: RFR: JDK-8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing

2024-04-09 Thread Matthias Baesken
On Tue, 9 Apr 2024 15:28:08 GMT, Matthias Baesken wrote: > We have already good JLI tracing capabilities. But GetApplicationHome and > GetApplicationHomeFromDll lack some tracing and should be enhanced. Btw. I noticed that GetModuleFileName return value is not checked, should this be done (at

RFR: JDK-8329862: GetApplicationHome and GetApplicationHomeFromDll enhance jli tracing

2024-04-09 Thread Matthias Baesken
We have already good JLI tracing capabilities. But GetApplicationHome and GetApplicationHomeFromDll lack some tracing and should be enhanced. - Commit messages: - JDK-8329862 Changes: https://git.openjdk.org/jdk/pull/18699/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=18