Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v3]

2024-02-02 Thread Joe Darcy
> The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the me

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-02 Thread Magnus Ihse Bursie
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Per Minborg
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Maurizio Cimadamore
On Thu, 1 Feb 2024 22:19:26 GMT, Joe Darcy wrote: >> The restricted javac warning is disabled for java.base, but could be enabled >> by suppressing the warning in a handful of files. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Joe Darcy
On Thu, 1 Feb 2024 22:01:49 GMT, Jorn Vernee wrote: > This looks good to me. It will be easier to find where we are doing > restricted operations like this. Right; follows the recommended approach of minimizing the scope of the SuppressWarnings annotations too. Thanks. - PR Comme

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base [v2]

2024-02-01 Thread Joe Darcy
> The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Add comment highlighting restricted method calls. --

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base

2024-02-01 Thread Jorn Vernee
On Thu, 1 Feb 2024 21:10:48 GMT, Joe Darcy wrote: > The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. This looks good to me. It will be easier to find where we are doing restricted operations like this. ---

Re: RFR: JDK-8325148: Enable restricted javac warning in java.base

2024-02-01 Thread Erik Joelsson
On Thu, 1 Feb 2024 21:10:48 GMT, Joe Darcy wrote: > The restricted javac warning is disabled for java.base, but could be enabled > by suppressing the warning in a handful of files. Marked as reviewed by erikj (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17677#pullrequ

RFR: JDK-8325148: Enable restricted javac warning in java.base

2024-02-01 Thread Joe Darcy
The restricted javac warning is disabled for java.base, but could be enabled by suppressing the warning in a handful of files. - Commit messages: - JDK-8325148: Enable restricted javac warning in java.base Changes: https://git.openjdk.org/jdk/pull/17677/files Webrev: https://webre