Re: RFR: JDK-8322979: Add informative discussion to Modifier [v4]

2024-08-22 Thread Pavel Rappo
On Thu, 11 Jan 2024 09:38:50 GMT, Alan Bateman wrote: >> src/java.base/share/classes/java/lang/reflect/Modifier.java line 238: >> >>> 236: * modifiers of a class or member, source-level modifiers that do >>> 237: * not not have a constant in the this class should be >>> 238: * inc

Re: RFR: JDK-8322979: Add informative discussion to Modifier [v4]

2024-01-12 Thread Joe Darcy
> Add a few apiNote concerning source-level modifiers that are not represented > in java.lang.reflect.Modifier. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Reflow paragraph. - Changes: - all: https://git.openjdk.org/

Re: RFR: JDK-8322979: Add informative discussion to Modifier [v3]

2024-01-12 Thread Alan Bateman
On Fri, 12 Jan 2024 07:38:12 GMT, Joe Darcy wrote: >> Add a few apiNote concerning source-level modifiers that are not represented >> in java.lang.reflect.Modifier. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Refine wordi

Re: RFR: JDK-8322979: Add informative discussion to Modifier [v3]

2024-01-11 Thread Joe Darcy
> Add a few apiNote concerning source-level modifiers that are not represented > in java.lang.reflect.Modifier. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Refine wording per review feedback. - Changes: - all: https:

Re: RFR: JDK-8322979: Add informative discussion to Modifier [v2]

2024-01-11 Thread Alan Bateman
On Wed, 10 Jan 2024 10:17:10 GMT, Pavel Rappo wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implement review feedback. > > src/java.base/share/classes/java/lang/reflect/Modifier.java line 238: > >> 236: * modi

Re: RFR: JDK-8322979: Add informative discussion to Modifier [v2]

2024-01-10 Thread Joe Darcy
> Add a few apiNote concerning source-level modifiers that are not represented > in java.lang.reflect.Modifier. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Implement review feedback. - Changes: - all: https://git.ope

Re: RFR: JDK-8322979: Add informative discussion to Modifier

2024-01-10 Thread Pavel Rappo
On Wed, 10 Jan 2024 06:00:18 GMT, Joe Darcy wrote: > Add a few apiNote concerning source-level modifiers that are not represented > in java.lang.reflect.Modifier. src/java.base/share/classes/java/lang/reflect/Modifier.java line 237: > 235: * To make a high-fidelity representation of the J

Re: RFR: JDK-8322979: Add informative discussion to Modifier

2024-01-10 Thread Alan Bateman
On Wed, 10 Jan 2024 06:00:18 GMT, Joe Darcy wrote: > Add a few apiNote concerning source-level modifiers that are not represented > in java.lang.reflect.Modifier. src/java.base/share/classes/java/lang/reflect/Modifier.java line 237: > 235: * To make a high-fidelity representation of the J

RFR: JDK-8322979: Add informative discussion to Modifier

2024-01-09 Thread Joe Darcy
Add a few apiNote concerning source-level modifiers that are not represented in java.lang.reflect.Modifier. - Commit messages: - JDK-8322979: Add informative discussion to Modifier Changes: https://git.openjdk.org/jdk/pull/17338/files Webrev: https://webrevs.openjdk.org/?repo=jdk&