Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

2023-11-21 Thread Lance Andersen
On Mon, 20 Nov 2023 19:15:18 GMT, Justin Lu wrote: >> Please review this PR which allows these _j.util_ tests to launch new JVM >> processes with VM flags, >> >> This is primarily done using by switching to >> `ProcessTools::createTestJavaProcessBuilder`. > > Justin Lu has updated the pull req

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

2023-11-20 Thread Naoto Sato
On Mon, 20 Nov 2023 19:15:18 GMT, Justin Lu wrote: >> Please review this PR which allows these _j.util_ tests to launch new JVM >> processes with VM flags, >> >> This is primarily done using by switching to >> `ProcessTools::createTestJavaProcessBuilder`. > > Justin Lu has updated the pull req

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

2023-11-20 Thread Justin Lu
> Please review this PR which allows these _j.util_ tests to launch new JVM > processes with VM flags, > > This is primarily done using by switching to > `ProcessTools::createTestJavaProcessBuilder`. Justin Lu has updated the pull request incrementally with one additional commit since the last

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v3]

2023-11-20 Thread Justin Lu
On Fri, 17 Nov 2023 20:17:28 GMT, Justin Lu wrote: >> test/jdk/java/util/Currency/PropertiesTest.sh line 30: >> >>> 28: # @summary tests the capability of replacing the currency data with user >>> 29: # specified currency properties file >>> 30: # @requires vm.flagless >> >> Does this actua

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags [v2]

2023-11-20 Thread Daniel Fuchs
On Fri, 17 Nov 2023 20:20:43 GMT, Justin Lu wrote: >> Please review this PR which allows these _j.util_ tests to launch new JVM >> processes with VM flags, >> >> This is primarily done using by switching to >> `ProcessTools::createTestJavaProcessBuilder`. >> >> _PropertiesTest.sh_ was updated

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags. [v2]

2023-11-17 Thread Justin Lu
On Fri, 17 Nov 2023 19:36:21 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reflect review comments > > test/jdk/java/util/Currency/PropertiesTest.sh line 30: > >> 28: # @summary tests the capability

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags. [v2]

2023-11-17 Thread Justin Lu
> Please review this PR which allows these _j.util_ tests to launch new JVM > processes with VM flags, > > This is primarily done using by switching to > `ProcessTools::createTestJavaProcessBuilder`. > > _PropertiesTest.sh_ was updated with `@requires vm.flagless`. Justin Lu has updated the pu

Re: RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags.

2023-11-17 Thread Naoto Sato
On Fri, 17 Nov 2023 09:25:40 GMT, Justin Lu wrote: > Please review this PR which allows these _j.util_ tests to launch new JVM > processes with VM flags, > > This is primarily done using by switching to > `ProcessTools::createTestJavaProcessBuilder`. > > _PropertiesTest.sh_ was updated with `

RFR: JDK-8319569: Several java/util tests should be updated to accept VM flags.

2023-11-17 Thread Justin Lu
Please review this PR which allows these _j.util_ tests to launch new JVM processes with VM flags, This is primarily done using by switching to `ProcessTools::createTestJavaProcessBuilder`. _PropertiesTest.sh_ was updated with `@requires vm.flagless`. - Commit messages: - init C