> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with two additional
commits since the last revision:
- Re-flow paragraph.
- Fix a typo.
-
Changes:
- all: https://git.openjdk.org/jdk/
Hi Hans,
Giving some additional context, we'll occasionally get bug reports that
amount to an observation equivalent to the following:
"I have two Big{Foo} variables and in a loop I assign larger and larger
values to them. As the values get large, bigFoo1.add(bigFoo2) runs much
faster than b
On Mon, 23 Oct 2023 20:26:00 GMT, Joe Darcy wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 302:
>>
>>> 300: * scale. For example, an {@linkplain BigDecimal#multiply(BigDecimal)
>>> 301: * exact multiply} of two {@code BigDecimal} values is subject to the
>>> 302: * same
On Mon, 23 Oct 2023 20:47:42 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback, fix ty
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback, fix typos.
-
Changes:
- all: https://git.openjdk.org/j
On Mon, 23 Oct 2023 20:07:07 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigInteger.java line 137:
>
>> 135: * results indicate a multipl
On Mon, 23 Oct 2023 20:05:50 GMT, Brian Burkhalter wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix typo.
>
> src/java.base/share/classes/java/math/BigDecimal.java line 302:
>
>> 300: * scale. For example, an {@l
On Mon, 23 Oct 2023 03:50:50 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
src/java.base/share/cla
Since I think this is about asymptotic complexity, which is determined by
behavior on large inputs, is there a reason to talk about switching to
other algorithms on smaller inputs? We certainly don't want to get into the
habit of listing "easy case" optimizations everywhere.
I'm unclear about the
On Mon, 23 Oct 2023 03:50:50 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix typo.
I suggest taking a look
On Mon, 23 Oct 2023 03:46:54 GMT, Joe Darcy wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Respond to review feedback.
src/j
On Mon, 23 Oct 2023 09:55:16 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to review feedback.
>
> src/java.base/share/classes/java/math/BigInteger.java line 127:
>
>> 125: * the
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Fix typo.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16298/files
- new:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/162
On Sun, 22 Oct 2023 11:22:27 GMT, Raffaello Giulietti
wrote:
>> Add informative notes to BigInteger and BigDecimal about possible running
>> times, etc.
>
> src/java.base/share/classes/java/math/BigInteger.java line 152:
>
>> 150: * time of operations can screen out {@code BigInteger} values
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
src/java.base/share/classes/java/math/BigDecimal.java line 310:
> 308: * time of operations can screen out {@code BigDecimal} values with
> 309: * unsc
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote:
> Add informative notes to BigInteger and BigDecimal about possible running
> times, etc.
The wording looks okay to me and I expect it will appear as an API note in
BigInteger.
However, for BigDecimal I suspect the h2 headings (for the next h
Add informative notes to BigInteger and BigDecimal about possible running
times, etc.
-
Commit messages:
- Appease jcheck.
- JDK-8318476: Add resource consumption note to BigInteger and BigDecimal
Changes: https://git.openjdk.org/jdk/pull/16298/files
Webrev: https://webrevs.openj
18 matches
Mail list logo
