Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms [v3]

2023-08-17 Thread Joe Darcy
> Use of javadoc search index feature; I'll re-flow paragraphs before pushing > once the wording is agreed to. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Reflow-paragraphs. - Changes: - all: https://git.openjdk.org/

Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms [v2]

2023-08-17 Thread Joe Darcy
On Thu, 17 Aug 2023 08:32:26 GMT, Alan Bateman wrote: > This looks okay to me. You might want to move the "For a" on L58 to the next > line to avoid L58 stick out too much, up to you. Sure; I usually prefer to re-flow the paragraphs after the text changes are agreed to so the difference is eas

Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms [v2]

2023-08-17 Thread Joe Darcy
> Use of javadoc search index feature; I'll re-flow paragraphs before pushing > once the wording is agreed to. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.ope

Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms [v2]

2023-08-17 Thread Joe Darcy
On Thu, 17 Aug 2023 13:00:40 GMT, Raffaello Giulietti wrote: > What about `semi-monotonic` on L.80? Does it deserve to be tagged as > `` and indexed? Good idea; added. The term "IEEE 754" is already index from various section titles so I didn't add an index item for that explicitly.

Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms

2023-08-17 Thread Raffaello Giulietti
On Thu, 17 Aug 2023 04:52:59 GMT, Joe Darcy wrote: > Use of javadoc search index feature; I'll re-flow paragraphs before pushing > once the wording is agreed to. What about `semi-monotonic` on L.80? Does it deserve to be tagged as `` and indexed? - PR Review: https://git.openjdk.o

Re: RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms

2023-08-17 Thread Alan Bateman
On Thu, 17 Aug 2023 04:52:59 GMT, Joe Darcy wrote: > Use of javadoc search index feature; I'll re-flow paragraphs before pushing > once the wording is agreed to. This looks okay to me. You might want to move the "For a" on L58 to the next line to avoid L58 stick out too much, up to you. -

RFR: JDK-8314489: Add javadoc index entries for java.lang.Math terms

2023-08-16 Thread Joe Darcy
Use of javadoc search index feature; I'll re-flow paragraphs before pushing once the wording is agreed to. - Commit messages: - JDK-8314489: Add javadoc index entries for java.lang.Math terms Changes: https://git.openjdk.org/jdk/pull/15322/files Webrev: https://webrevs.openjdk.org