Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-21 Thread Thomas Stuefe
On Wed, 21 Jun 2023 07:55:31 GMT, David Holmes wrote: >> I'm not aware of any other uses either; its not intended to be used outside >> of ProcessImpl especially since the addition of the new protocol to >> communicate parameters and confirm launching of the child. > > This curiosity has been p

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-21 Thread David Holmes
On Tue, 20 Jun 2023 16:27:38 GMT, Roger Riggs wrote: >> I wondered about this, it looked so deliberate. So I wondered whether >> jspawnhelper is used outside of the posix_spawn context, but cannot find >> anything. Maybe historic? > > I'm not aware of any other uses either; its not intended to

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-20 Thread Roger Riggs
On Tue, 20 Jun 2023 15:08:13 GMT, Thomas Stuefe wrote: >> src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 139: >> >>> 137: ChildStuff c; >>> 138: struct stat buf; >>> 139: /* argv[1] contains the fd number to read all the child info */ >> >> I would prefer to also fix the

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-20 Thread Thomas Stuefe
On Tue, 20 Jun 2023 15:00:29 GMT, Roger Riggs wrote: >> Thomas Stuefe has updated the pull request incrementally with one additional >> commit since the last revision: >> >> correct comment > > src/java.base/unix/native/jspawnhelper/jspawnhelper.c line 139: > >> 137: ChildStuff c; >> 138

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-20 Thread Roger Riggs
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For detai

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Volker Simonis
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For detai

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For detai

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Thomas Stuefe
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For detai

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-19 Thread Aleksey Shipilev
On Mon, 19 Jun 2023 06:07:26 GMT, Thomas Stuefe wrote: >> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] >> >> jspawnhelper uses argv[0] to receive the fd string from the parent. That >> breaks with conventions and trips over certain tools like binfmt_misc. >> >> For detai

Re: RFR: JDK-8310265: (process) jspawnhelper should not use argv[0] [v2]

2023-06-18 Thread Thomas Stuefe
> Reported by [jarabe...@gmail.com](mailto:jarabe...@gmail.com) [1] > > jspawnhelper uses argv[0] to receive the fd string from the parent. That > breaks with conventions and trips over certain tools like binfmt_misc. > > For details, see linked ML discussion. > > [1] https://mail.openjdk.or