Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets [v2]

2023-05-30 Thread Joe Darcy
On Sun, 28 May 2023 18:50:45 GMT, Alan Bateman wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > src/java.base/share/classes/java/lang/Class.java line 426: > >> 424: * {@snippet lan

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets [v2]

2023-05-30 Thread Alan Bateman
On Tue, 30 May 2023 16:42:05 GMT, Joe Darcy wrote: >> Straightforward doc refactoring to use snippets. > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review feedback. Marked as reviewed by alanb (Reviewer). -

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets [v2]

2023-05-30 Thread Joe Darcy
> Straightforward doc refactoring to use snippets. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/14194/files - new: https://git.openjdk.or

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-30 Thread Joe Darcy
On Sat, 27 May 2023 22:31:28 GMT, Chen Liang wrote: >> Straightforward doc refactoring to use snippets. > > src/java.base/share/classes/java/lang/Class.java line 356: > >> 354: * >> 355: * {@snippet lang="java" : >> 356: * Class t = Class.forName("java.lang.Thread") > > This sh

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-28 Thread Alan Bateman
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote: > Straightforward doc refactoring to use snippets. src/java.base/share/classes/java/lang/Class.java line 426: > 424: * {@snippet lang="java" : > 425: * Class.forName("Foo", true, this.getClass().getClassLoader()) > 426: * } Not

Re: RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-27 Thread Chen Liang
On Sat, 27 May 2023 21:04:51 GMT, Joe Darcy wrote: > Straightforward doc refactoring to use snippets. src/java.base/share/classes/java/lang/Class.java line 356: > 354: * > 355: * {@snippet lang="java" : > 356: * Class t = Class.forName("java.lang.Thread") This should have a fi

RFR: JDK-8308987: Update java.lang.Class to use javadoc snippets

2023-05-27 Thread Joe Darcy
Straightforward doc refactoring to use snippets. - Commit messages: - JDK-8308987: Update java.lang.Class to use javadoc snippets Changes: https://git.openjdk.org/jdk/pull/14194/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14194&range=00 Issue: https://bugs.openjdk.org/