Re: RFR: JDK-8304423: Refactor FdLibm.java

2023-04-25 Thread Brian Burkhalter
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy wrote: > Minor refactoring of FdLibm.java; will consider future refactorings with more > substantive code changes in the future. LGTM2 - Marked as reviewed by bpb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/13604#pullrequest

Re: RFR: JDK-8304423: Refactor FdLibm.java

2023-04-24 Thread Joe Darcy
On Mon, 24 Apr 2023 12:00:58 GMT, Raffaello Giulietti wrote: >> Minor refactoring of FdLibm.java; will consider future refactorings with >> more substantive code changes in the future. > > src/java.base/share/classes/java/lang/FdLibm.java line 76: > >> 74: private static final int SIGN_BIT

Re: RFR: JDK-8304423: Refactor FdLibm.java

2023-04-24 Thread Raffaello Giulietti
On Sun, 23 Apr 2023 22:34:43 GMT, Joe Darcy wrote: > Minor refactoring of FdLibm.java; will consider future refactorings with more > substantive code changes in the future. src/java.base/share/classes/java/lang/FdLibm.java line 76: > 74: private static final int SIGN_BIT= 0x8000_00

RFR: JDK-8304423: Refactor FdLibm.java

2023-04-23 Thread Joe Darcy
Minor refactoring of FdLibm.java; will consider future refactorings with more substantive code changes in the future. - Commit messages: - JDK-8304423: Refactor Fdlibm.java Changes: https://git.openjdk.org/jdk/pull/13604/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=13604