Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-27 Thread Tagir F . Valeev
On Mon, 27 Feb 2023 13:20:48 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903: >> >>> 1901: int total = count * length; >>> 1902: int limit = offset + total; >>> 1903: ensureCapacityInternal(limit); >> >> If I understan

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-27 Thread Jim Laskey
On Sun, 26 Feb 2023 17:28:08 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PR Cleanup > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1903: > >> 1901: int tot

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-27 Thread Jim Laskey
On Sun, 26 Feb 2023 17:29:09 GMT, Tagir F. Valeev wrote: >> Jim Laskey has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PR Cleanup > > src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1893: > >> 1891: } >> 18

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-26 Thread Tagir F . Valeev
On Thu, 23 Feb 2023 17:39:10 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PR Cleanup src/java.ba

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-26 Thread Tagir F . Valeev
On Thu, 23 Feb 2023 16:17:00 GMT, Jim Laskey wrote: >> src/java.base/share/classes/java/lang/AbstractStringBuilder.java line 1839: >> >>> 1837: * @throws StringIndexOutOfBoundsException if the result >>> overflows the buffer >>> 1838: */ >>> 1839: public AbstractStringBuilder rep

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-23 Thread Raffaello Giulietti
On Thu, 23 Feb 2023 17:39:10 GMT, Jim Laskey wrote: >> Add the ability to repeatedly append char and CharSequence data to >> StringBuilder/StringBuffer. > > Jim Laskey has updated the pull request incrementally with one additional > commit since the last revision: > > PR Cleanup src/java.ba

Re: RFR: JDK-8302323 Add repeat methods to StringBuilder/StringBuffer [v2]

2023-02-23 Thread Jim Laskey
> Add the ability to repeatedly append char and CharSequence data to > StringBuilder/StringBuffer. Jim Laskey has updated the pull request incrementally with one additional commit since the last revision: PR Cleanup - Changes: - all: https://git.openjdk.org/jdk/pull/12728/file