Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-06 Thread Joe Darcy
On Mon, 6 Feb 2023 08:19:36 GMT, Alan Bateman wrote: > @jddarcy Are you planning a GC of unused functions in StrictMath.c too? (for > this PR I'm wondering about Java_java_lang_StrictMath_expm1). Yes, once the port is done, I'll remove all the remaining FDLIBM C files. There are dependencies b

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-06 Thread Alan Bateman
On Fri, 3 Feb 2023 21:04:15 GMT, Joe Darcy wrote: >> Next on the FDLIBM C -> Java port, expm1. >> Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! >> >> For expm1, the C vs transliteration port show the usual kind of differences, >> beside formatting of the constants, the use of the

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Brian Burkhalter
On Fri, 3 Feb 2023 21:04:15 GMT, Joe Darcy wrote: >> Next on the FDLIBM C -> Java port, expm1. >> Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! >> >> For expm1, the C vs transliteration port show the usual kind of differences, >> beside formatting of the constants, the use of the

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Joe Darcy
On Fri, 3 Feb 2023 07:03:51 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback; use // comments > > src/java.base/share/classes/java/lang/FdLibm.java line 1147: > >> 1145:

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java [v2]

2023-02-03 Thread Joe Darcy
> Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI macro on the > left-hand side needs to be replaced

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java

2023-02-03 Thread Raffaello Giulietti
On Thu, 2 Feb 2023 22:18:32 GMT, Joe Darcy wrote: > Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI

Re: RFR: JDK-8301396: Port fdlibm expm1 to Java

2023-02-02 Thread Andrey Turbanov
On Thu, 2 Feb 2023 22:18:32 GMT, Joe Darcy wrote: > Next on the FDLIBM C -> Java port, expm1. > Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! > > For expm1, the C vs transliteration port show the usual kind of differences, > beside formatting of the constants, the use of the __HI

RFR: JDK-8301396: Port fdlibm expm1 to Java

2023-02-02 Thread Joe Darcy
Next on the FDLIBM C -> Java port, expm1. Coming soon, hyperbolic transcendentals (sinh, cosh, tanh)! For expm1, the C vs transliteration port show the usual kind of differences, beside formatting of the constants, the use of the __HI macro on the left-hand side needs to be replaced by a method