Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v5]

2023-02-02 Thread Brian Burkhalter
On Thu, 2 Feb 2023 18:06:00 GMT, Joe Darcy wrote: >> Another day, another PR to port FDLBIM to Java, this time for the log1p >> method. >> >> Other than using the two-argument form of the __HI method in Java >> transliteration version rather than C macro, there are no appreciable >> differenc

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v4]

2023-02-02 Thread Joe Darcy
On Thu, 2 Feb 2023 10:04:39 GMT, Raffaello Giulietti wrote: >> test/jdk/java/lang/StrictMath/Log1pTests.java line 245: >> >>> 243: -0x1.0p-54, >>> 244: 0x1.0p-54, >>> 245: >> >> maybe add a comment like >> `/* approximations around sqrt(2)/2 - 1 and around sqrt(2) -

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v5]

2023-02-02 Thread Joe Darcy
> Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences between the original C source in > > src/java.base/sh

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v4]

2023-02-02 Thread Raffaello Giulietti
On Thu, 2 Feb 2023 10:03:29 GMT, Raffaello Giulietti wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Improve spacing. > > test/jdk/java/lang/StrictMath/Log1pTests.java line 245: > >> 243: -0x1.0p-54, >>

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v4]

2023-02-02 Thread Raffaello Giulietti
On Wed, 1 Feb 2023 19:19:05 GMT, Joe Darcy wrote: >> Another day, another PR to port FDLBIM to Java, this time for the log1p >> method. >> >> Other than using the two-argument form of the __HI method in Java >> transliteration version rather than C macro, there are no appreciable >> differenc

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v4]

2023-02-01 Thread Joe Darcy
> Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences between the original C source in > > src/java.base/sh

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v3]

2023-02-01 Thread Joe Darcy
On Wed, 1 Feb 2023 07:16:25 GMT, Joe Darcy wrote: >> Another day, another PR to port FDLBIM to Java, this time for the log1p >> method. >> >> Other than using the two-argument form of the __HI method in Java >> transliteration version rather than C macro, there are no appreciable >> differenc

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v3]

2023-01-31 Thread Joe Darcy
> Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences between the original C source in > > src/java.base/sh

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v2]

2023-01-31 Thread Joe Darcy
On Tue, 31 Jan 2023 06:49:28 GMT, Andrey Turbanov wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Implement review feedback. > > src/java.base/share/classes/java/lang/FdLibm.java line 911: > >> 909: k = 1

Re: RFR: JDK-8301392: Port fdlibm log1p to Java [v2]

2023-01-31 Thread Joe Darcy
> Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences between the original C source in > > src/java.base/sh

Re: RFR: JDK-8301392: Port fdlibm log1p to Java

2023-01-31 Thread Joe Darcy
On Tue, 31 Jan 2023 06:45:27 GMT, Andrey Turbanov wrote: >> Another day, another PR to port FDLBIM to Java, this time for the log1p >> method. >> >> Other than using the two-argument form of the __HI method in Java >> transliteration version rather than C macro, there are no appreciable >> di

Re: RFR: JDK-8301392: Port fdlibm log1p to Java

2023-01-31 Thread Raffaello Giulietti
On Tue, 31 Jan 2023 02:52:45 GMT, Joe Darcy wrote: > Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences be

Re: RFR: JDK-8301392: Port fdlibm log1p to Java

2023-01-30 Thread Andrey Turbanov
On Tue, 31 Jan 2023 02:52:45 GMT, Joe Darcy wrote: > Another day, another PR to port FDLBIM to Java, this time for the log1p > method. > > Other than using the two-argument form of the __HI method in Java > transliteration version rather than C macro, there are no appreciable > differences be

RFR: JDK-8301392: Port fdlibm log1p to Java

2023-01-30 Thread Joe Darcy
Another day, another PR to port FDLBIM to Java, this time for the log1p method. Other than using the two-argument form of the __HI method in Java transliteration version rather than C macro, there are no appreciable differences between the original C source in src/java.base/share/native/libfdl