Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-25 Thread Viktor Klang
On Thu, 25 May 2023 07:35:39 GMT, David Holmes wrote: >> @AlanBateman Sounds good, thanks for confirming. I've updated both the >> ProblemLists, but it needed yet another rebase, so yet another forced push. > >> it needed yet another rebase, so yet another forced push. > > You don't need to reb

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-25 Thread David Holmes
On Wed, 24 May 2023 08:30:21 GMT, Viktor Klang wrote: > it needed yet another rebase, so yet another forced push. You don't need to rebase (and force-push) you just merge with the master branch and skara will take care of flattening the commits. - PR Comment: https://git.openjdk.o

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-24 Thread Viktor Klang
On Wed, 24 May 2023 06:07:54 GMT, Alan Bateman wrote: >> Viktor Klang has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains two commits: >> >> - Removing OOMEInAQS from zgc problem list >> - JDK-8298066: Increasing max heap size for O

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v4]

2023-05-24 Thread Viktor Klang
> Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea Viktor Klang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated cha

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-23 Thread Alan Bateman
On Tue, 23 May 2023 09:02:27 GMT, Viktor Klang wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Viktor Klang has updated the pull request with a new target base due to a > mer

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-23 Thread Alan Bateman
On Tue, 23 May 2023 09:02:27 GMT, Viktor Klang wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Viktor Klang has updated the pull request with a new target base due to a > mer

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v3]

2023-05-23 Thread Viktor Klang
> Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea Viktor Klang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Re

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v2]

2023-05-23 Thread Viktor Klang
On Tue, 23 May 2023 08:27:39 GMT, Viktor Klang wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Viktor Klang has refreshed the contents of this pull request, and previous > co

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v2]

2023-05-23 Thread Alan Bateman
On Tue, 23 May 2023 08:22:22 GMT, Viktor Klang wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Viktor Klang has updated the pull request incrementally with one additional > c

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-23 Thread Viktor Klang
On Tue, 23 May 2023 07:19:42 GMT, David Holmes wrote: >> @AlanBateman I wonder, perhaps it makes more sense, as you say, to clear the >> problem list together with this, and resurrect it in case it spuriously >> resurfaces. It's always a challenge to prove a negative. :) > > @viktorklang-ora i

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out [v2]

2023-05-23 Thread Viktor Klang
> Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: Removing OOMEInAQS from zgc pro

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-23 Thread David Holmes
On Mon, 22 May 2023 20:23:20 GMT, Viktor Klang wrote: >>> @AlanBateman My thinking was to integrate this and make sure that the >>> problem doesn't resurface before removing it from the problem list. Does >>> that make sense? 🤔 >> >> No objection, it's just it would leave ProblemList-generatio

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-22 Thread Viktor Klang
On Mon, 22 May 2023 14:46:02 GMT, Alan Bateman wrote: >> Should the test be removed from ProblemList-generational-zgc.txt as part of >> this? > >> @AlanBateman My thinking was to integrate this and make sure that the >> problem doesn't resurface before removing it from the problem list. Does >

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 13:28:24 GMT, Alan Bateman wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Should the test be removed from ProblemList-generational-zgc.txt as part of > t

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-22 Thread Viktor Klang
On Mon, 22 May 2023 13:28:24 GMT, Alan Bateman wrote: >> Doubling the max heap size since not all GCs might have compressed OOPs, so >> this change should make this test more robust. >> >> Cleared with @DougLea > > Should the test be removed from ProblemList-generational-zgc.txt as part of > t

Re: RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-22 Thread Alan Bateman
On Mon, 22 May 2023 13:12:02 GMT, Viktor Klang wrote: > Doubling the max heap size since not all GCs might have compressed OOPs, so > this change should make this test more robust. > > Cleared with @DougLea Should the test be removed from ProblemList-generational-zgc.txt as part of this? ---

RFR: JDK-8298066: java/util/concurrent/locks/Lock/OOMEInAQS.java timed out

2023-05-22 Thread Viktor Klang
Doubling the max heap size since not all GCs might have compressed OOPs, so this change should make this test more robust. Cleared with @DougLea - Commit messages: - JDK-8298066: Increasing max heap size for OOMEinAQS since not all GCs might have compressed oops Changes: https://