On Tue, 29 Nov 2022 20:35:00 GMT, Joe Darcy wrote:
>> Remove redundant code reported in
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove w
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Remove whitespace.
-
Changes:
- all: https://git.openjdk.
On Tue, 29 Nov 2022 07:39:59 GMT, Andrey Turbanov wrote:
> IDEA now highlights unnecessary `rem.offset=1` assignments, which are above
> modified code. Now we always overwrite it with `0` anyway.
>
> https://github.com/openjdk/jdk/blob/6f06f440bcf8a5db379b80e8765af38a15449356/src/java.base/shar
On Mon, 28 Nov 2022 18:58:29 GMT, Joe Darcy wrote:
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
IDEA now highlights unnecessary `rem.offset=1` assignments, which are above
modified code.
Now we always overwrite it with `0` a
On Mon, 28 Nov 2022 19:56:23 GMT, Sergey Bylokhov wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 1536:
>>
>>> 1534:
>>> 1535: // Must insert leading 0 in rem if its length did not change
>>> 1536: if (rem.intLen == nlen) {
>>
>> Looks like after thi
On Mon, 28 Nov 2022 19:49:55 GMT, Sergey Bylokhov wrote:
>> Remove redundant code reported in
>>
>> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
>
> src/java.base/share/classes/java/math/MutableBigInteger.java line 1536:
>
>> 1534:
>> 1535: // Must insert
On Mon, 28 Nov 2022 18:58:29 GMT, Joe Darcy wrote:
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
src/java.base/share/classes/java/math/MutableBigInteger.java line 1536:
> 1534:
> 1535: // Must insert leading 0 in rem
On Mon, 28 Nov 2022 18:58:29 GMT, Joe Darcy wrote:
> Remove redundant code reported in
>
> https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
Marked as reviewed by bpb (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11395
Remove redundant code reported in
https://mail.openjdk.org/pipermail/core-libs-dev/2022-November/097163.html
-
Commit messages:
- JDK-8297731: Remove redundant check in MutableBigInteger.divide
Changes: https://git.openjdk.org/jdk/pull/11395/files
Webrev: https://webrevs.openjdk.o
