Re: RFR: JDK-8266670: Better modeling of access flags in core reflection [v30]

2022-06-17 Thread Rémi Forax
On Fri, 17 Jun 2022 14:42:22 GMT, Roger Riggs wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add module-related tests. > > src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 428: > >> 426:

Re: RFR: JDK-8266670: Better modeling of access flags in core reflection [v30]

2022-06-17 Thread Roger Riggs
On Fri, 17 Jun 2022 03:10:47 GMT, Joe Darcy wrote: >> This is an early review of changes to better model JVM access flags, that is >> "modifiers" like public, protected, etc. but explicitly at a VM level. >> >> Language level modifiers and JVM level access flags are closely related, but >> dis

Re: RFR: JDK-8266670: Better modeling of access flags in core reflection [v30]

2022-06-16 Thread Joe Darcy
> This is an early review of changes to better model JVM access flags, that is > "modifiers" like public, protected, etc. but explicitly at a VM level. > > Language level modifiers and JVM level access flags are closely related, but > distinct. There are concepts that overlap in the two domains