Re: RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v3]

2023-11-28 Thread Justin Lu
> Please review this PR which converts the shell test, > _java/util/currency/PropertiesTest.sh_ to a normal java test. > > This test is a test runner that launches test methods from > _PropertiesTest.java_. It tests both the ways to supersede the default > currencies, that is, either using a cu

Re: RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v3]

2023-11-28 Thread Lance Andersen
On Tue, 28 Nov 2023 20:49:38 GMT, Justin Lu wrote: >> Please review this PR which converts the shell test, >> _java/util/currency/PropertiesTest.sh_ to a normal java test. >> >> This test is a test runner that launches test methods from >> _PropertiesTest.java_. It tests both the ways to super

Re: RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v2]

2023-11-28 Thread Naoto Sato
On Tue, 28 Nov 2023 18:28:37 GMT, Justin Lu wrote: >> Please review this PR which converts the shell test, >> _java/util/currency/PropertiesTest.sh_ to a normal java test. >> >> This test is a test runner that launches test methods from >> _PropertiesTest.java_. It tests both the ways to super

Re: RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests [v2]

2023-11-28 Thread Justin Lu
> Please review this PR which converts the shell test, > _java/util/currency/PropertiesTest.sh_ to a normal java test. > > This test is a test runner that launches test methods from > _PropertiesTest.java_. It tests both the ways to supersede the default > currencies, that is, either using a cu

RFR: JDK-8210410: Refactor java.util.Currency:i18n shell tests to plain java tests

2023-11-22 Thread Justin Lu
Please review this PR which converts the shell test, _java/util/currency/PropertiesTest.sh_ to a normal java test. This test is a test runner that launches test methods from _PropertiesTest.java_. It tests both the ways to supersede the default currencies, that is, either using a custom propert