On Tue, 9 May 2023 14:22:39 GMT, Roger Riggs wrote:
>> @RogerRiggs "the" instead of "a" gives me the impression that the
>> Spliterator only has a single element left. The choice of colon instead of a
>> comma is because "If a remaining element exists" introduces a list of 2
>> elements (and i
On Tue, 9 May 2023 09:21:08 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/Spliterator.java line 298:
>>
>>> 296: public interface Spliterator {
>>> 297: /**
>>> 298: * If a remaining element exists: performs the given action on it,
>>
>> I'm not sure the ":" is an i
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 21:00:32 GMT, Roger Riggs wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/classes/java/util/Spliterator.java
>>
>> Co-authored-by: Paul Sandoz
>
> src/java.base/s
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 19:07:17 GMT, Viktor Klang wrote:
>> Attempting to make the "at-most once" nature, of invoking the supplied
>> action to tryAdvance, clearer in the JavaDoc.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 May 2023 10:32:48 GMT, Viktor Klang wrote:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
@PaulSandoz Great suggestion, thank you Paul!
-
PR Comment: https://git.openjdk.org/jdk/pull/13860#issuecom
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
Update src/java.base/share/classes/java/util/Spliterator.java
On Mon, 8 May 2023 10:32:48 GMT, Viktor Klang wrote:
> Attempting to make the "at-most once" nature, of invoking the supplied action
> to tryAdvance, clearer in the JavaDoc.
src/java.base/share/classes/java/util/Spliterator.java line 307:
> 305: * an exception.
> 306: *
> 307: *
Attempting to make the "at-most once" nature, of invoking the supplied action
to tryAdvance, clearer in the JavaDoc.
-
Commit messages:
- JDK-8133773: clarify specification of Spliterator.tryAdvance
Changes: https://git.openjdk.org/jdk/pull/13860/files
Webrev: https://webrevs.open
11 matches
Mail list logo
