Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v6]

2024-02-29 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) > which defines the behavior for creating ChoiceFormats with incorrect > patterns. The wording is added to both the ChoiceFormat constructor and > ChoiceFormat::applyPattern method. > > While ideally the inconsistent

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v5]

2024-02-29 Thread Naoto Sato
On Thu, 29 Feb 2024 20:07:14 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) >> which defines the behavior for creating ChoiceFormats with incorrect >> patterns. The wording is added to both the ChoiceFormat constructor and >> ChoiceFormat:

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v5]

2024-02-29 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) > which defines the behavior for creating ChoiceFormats with incorrect > patterns. The wording is added to both the ChoiceFormat constructor and > ChoiceFormat::applyPattern method. > > While ideally the inconsistent

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v4]

2024-02-22 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) > which defines the behavior for creating ChoiceFormats with incorrect > patterns. The wording is added to both the ChoiceFormat constructor and > ChoiceFormat::applyPattern method. > > While ideally the inconsistent

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v3]

2024-02-16 Thread Naoto Sato
On Fri, 16 Feb 2024 23:35:10 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) >> which defines the behavior for creating ChoiceFormats with incorrect >> patterns. The wording is added to both the ChoiceFormat constructor and >> ChoiceFormat:

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v2]

2024-02-16 Thread Justin Lu
On Fri, 16 Feb 2024 22:38:11 GMT, Naoto Sato wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> replace spec tag with note > > src/java.base/share/classes/java/text/ChoiceFormat.java line 235: > >> 233: * >> 234:

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v3]

2024-02-16 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) > which defines the behavior for creating ChoiceFormats with incorrect > patterns. The wording is added to both the ChoiceFormat constructor and > ChoiceFormat::applyPattern method. > > While ideally the inconsistent

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v2]

2024-02-16 Thread Naoto Sato
On Fri, 16 Feb 2024 21:53:26 GMT, Justin Lu wrote: >> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) >> which defines the behavior for creating ChoiceFormats with incorrect >> patterns. The wording is added to both the ChoiceFormat constructor and >> ChoiceFormat:

Re: RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns [v2]

2024-02-16 Thread Justin Lu
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) > which defines the behavior for creating ChoiceFormats with incorrect > patterns. The wording is added to both the ChoiceFormat constructor and > ChoiceFormat::applyPattern method. > > While ideally the inconsistent

RFR: JDK-6801704: ChoiceFormat::applyPattern inconsistency for invalid patterns

2024-02-14 Thread Justin Lu
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756) which defines the behavior for creating ChoiceFormats with incorrect patterns. The wording is added to both the ChoiceFormat constructor and ChoiceFormat::applyPattern method. While ideally the inconsistent behavior it