On Sat, 25 Jan 2025 13:04:52 GMT, Shaojin Wen wrote:
> Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
> Double.toString, some code in FloatingDecimal is not used. This refactoring
> is to remove the unused code and reuse DecimalDigits to reduce duplication of
> code.
> Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
> Double.toString, some code in FloatingDecimal is not used. This refactoring
> is to remove the unused code and reuse DecimalDigits to reduce duplication of
> code.
Shaojin Wen has updated the pull request incrementally
On Sat, 25 Jan 2025 13:04:52 GMT, Shaojin Wen wrote:
> Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
> Double.toString, some code in FloatingDecimal is not used. This refactoring
> is to remove the unused code and reuse DecimalDigits to reduce duplication of
> code.
On Mon, 27 Jan 2025 00:22:42 GMT, Chen Liang wrote:
>> Creating a BinaryToASCIIConverter is not expensive and does not require the
>> use of cache, but this should be proven by performance testing.
>
> Each `BinaryToASCIIBuffer` allocates an array for digits. That might be why
> the buffer was
On Sun, 26 Jan 2025 23:42:24 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java line 988:
>>
>>> 986: return threadLocalBinaryToASCIIBuffer.get();
>>> 987: }
>>> 988:
>>
>> Why was this thread local buffer removed?
>
> Creating a BinaryToA
On Sat, 25 Jan 2025 13:04:52 GMT, Shaojin Wen wrote:
> Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
> Double.toString, some code in FloatingDecimal is not used. This refactoring
> is to remove the unused code and reuse DecimalDigits to reduce duplication of
> code.
On Sun, 26 Jan 2025 17:48:29 GMT, Chen Liang wrote:
>> Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
>> Double.toString, some code in FloatingDecimal is not used. This refactoring
>> is to remove the unused code and reuse DecimalDigits to reduce duplication
>> of code
On Sat, 14 Jun 2025 04:58:29 GMT, Shaojin Wen wrote:
>>> @wenshao I'm working on a general overhaul of FloatingDecimal and related
>>> classes in some current and future PRs.
>>>
>>> If you could restrict your changes to just DigitList, that would be less
>>> interference with my work.
>>
>>
On Thu, 12 Jun 2025 23:54:10 GMT, Shaojin Wen wrote:
>>> @wenshao How about extracting a new PR from this that only deals with
>>> removing the unused code?
>>
>> Yes, but I will wait until after June 5th so that it does not affect the
>> release of JDK 25.
>
>> @wenshao I'm working on a gener
On Fri, 2 May 2025 17:56:49 GMT, Johannes Graham wrote:
> @wenshao How about extracting a new PR from this that only deals with
> removing the unused code?
Yes, but I will wait until after June 5th so that it does not affect the
release of JDK 25.
-
PR Comment: https://git.openjd
On Wed, 7 May 2025 02:25:44 GMT, Shaojin Wen wrote:
>> @wenshao How about extracting a new PR from this that only deals with
>> removing the unused code?
>
>> @wenshao How about extracting a new PR from this that only deals with
>> removing the unused code?
>
> Yes, but I will wait until after
On Thu, 12 Jun 2025 23:54:10 GMT, Shaojin Wen wrote:
>>> @wenshao How about extracting a new PR from this that only deals with
>>> removing the unused code?
>>
>> Yes, but I will wait until after June 5th so that it does not affect the
>> release of JDK 25.
>
>> @wenshao I'm working on a gener
On Wed, 7 May 2025 02:25:44 GMT, Shaojin Wen wrote:
>> @wenshao How about extracting a new PR from this that only deals with
>> removing the unused code?
>
>> @wenshao How about extracting a new PR from this that only deals with
>> removing the unused code?
>
> Yes, but I will wait until after
Since FloatToDecimal and DoubleToDecimal are used in Float.toString and
Double.toString, some code in FloatingDecimal is not used. This refactoring is
to remove the unused code and reuse DecimalDigits to reduce duplication of code.
-
Commit messages:
- Merge remote-tracking branch
14 matches
Mail list logo
