On Mon, 4 Aug 2025 19:06:10 GMT, Roger Riggs wrote:
> This seems to be failing in the CI on the build of: linux-x64-debug-nopch
>
> ```
> [2025-08-04T19:02:29,373Z]
> //workspace/open/src/hotspot/cpu/x86/stubGenerator_x86_64_sinh.cpp:293:27:
> error: 'stub_id' was not declared in this
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 31 Jul 2025 21:32:16 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Wed, 30 Jul 2025 18:26:22 GMT, Sandhya Viswanathan
wrote:
>> Mohamed Issa has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move error bound to separate section in comment header
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sinh.cpp li
On Thu, 17 Jul 2025 18:46:06 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 17 Jul 2025 18:46:06 GMT, Mohamed Issa wrote:
>> The goal of this PR is to implement an x86_64 intrinsic for
>> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
>> included to check the performance of specific input value ranges to help
>> prevent regression
On Thu, 10 Jul 2025 21:23:50 GMT, Joe Darcy wrote:
> > > What is the accuracy of the algorithm in ulps (units the last place)?
> > > The java.lang.Math specification has max error and various other accuracy
> > > requirements any implementation must meet.
> >
> >
> > 0.51 ulps
>
> Please add
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in the future.
>
> The command to run all range specific
On Thu, 10 Jul 2025 14:31:02 GMT, Mohamed Issa wrote:
> > What is the accuracy of the algorithm in ulps (units the last place)?
> > The java.lang.Math specification has max error and various other accuracy
> > requirements any implementation must meet.
>
> 0.51 ulps
Please add that as a commen
On Thu, 10 Jul 2025 04:52:01 GMT, Joe Darcy wrote:
> What is the accuracy of the algorithm in ulps (units the last place)?
>
> The java.lang.Math specification has max error and various other accuracy
> requirements any implementation must meet.
0.51 ulps
-
PR Comment: https://gi
On Mon, 7 Jul 2025 23:53:14 GMT, Mohamed Issa wrote:
> I'm not sure which libm version you're referring to. The only current sinh
> benchmark I'm aware of is in MathBench.java, and the benchmarks in
> SinhPerf.java didn't exist until now. Could you clarify?
I didn't notice the code you ported
On Mon, 7 Jul 2025 03:05:15 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in
On Mon, 7 Jul 2025 04:48:18 GMT, Florian Weimer wrote:
> Isn't this effectively a libm benchmark (where the `sinh` implementation
> resides)? Please include the libm version for reference here. Thanks.
I'm not sure which libm version you're referring to. The only current sinh
benchmark I'm awa
On Mon, 7 Jul 2025 18:01:26 GMT, Joe Darcy wrote:
> Are there plans for a cosh intrinsic as follow-up work? There was a previous
> effort to intrinsify tanh.
Yes, the intention is to have cosh as next math intrinsic.
-
PR Comment: https://git.openjdk.org/jdk/pull/26152#issuecommen
On Mon, 7 Jul 2025 18:03:54 GMT, Joe Darcy wrote:
> A large fraction of floating-point numbers are in the [-2^(-28), 2^(-28)]
> range where there is a performance degradation with the new implementation.
>
> What is the expected distribution of arguments to sinh?
I don't know about an expected
On Mon, 7 Jul 2025 03:05:15 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in
On Mon, 7 Jul 2025 03:05:15 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in
On Mon, 7 Jul 2025 03:05:15 GMT, Mohamed Issa wrote:
> The goal of this PR is to implement an x86_64 intrinsic for
> java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
> included to check the performance of specific input value ranges to help
> prevent regressions in
The goal of this PR is to implement an x86_64 intrinsic for
java.lang.Math.sinh() using libm. There is a new set of micro-benchmarks are
included to check the performance of specific input value ranges to help
prevent regressions in the future.
The command to run all range specific micro-benchm
22 matches
Mail list logo
