Re: RFR: 8358426: Improve lazy computation in Locale [v2]

2025-06-09 Thread Justin Lu
On Thu, 5 Jun 2025 20:29:48 GMT, Justin Lu wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Values. >

Re: RFR: 8358426: Improve lazy computation in Locale [v2]

2025-06-09 Thread Justin Lu
On Sat, 7 Jun 2025 17:36:40 GMT, Johannes Graham wrote: >> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review - Moving all ISO resources to LocaleISOData & blessed modifier >> order for languageTag > > src/java.base/share/

Re: RFR: 8358426: Improve lazy computation in Locale [v2]

2025-06-07 Thread Johannes Graham
On Thu, 5 Jun 2025 20:29:48 GMT, Justin Lu wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Values. >

Re: RFR: 8358426: Improve lazy computation in Locale [v2]

2025-06-06 Thread Naoto Sato
On Thu, 5 Jun 2025 20:29:48 GMT, Justin Lu wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Values. >

Re: RFR: 8358426: Improve lazy computation in Locale [v2]

2025-06-05 Thread Justin Lu
> Please review this PR which improves occurrences of lazy computation in > `Locale` and `BaseLocale`. > > Existing lazy initialization strategies such as CHM, static nested class, and > local inner class are replaced with Stable Values. > > Lambda usage is intentionally avoided in this change

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Justin Lu
On Thu, 5 Jun 2025 11:50:01 GMT, Johannes Döbler wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Val

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Naoto Sato
On Thu, 5 Jun 2025 18:32:34 GMT, Justin Lu wrote: >> src/java.base/share/classes/java/util/Locale.java line 2578: >> >>> 2576: return Set.of(LocaleISOData.ISO3166_3); >>> 2577: } >>> 2578: }); >> >> What about moving these four stable suppliers an

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Johannes Döbler
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote: > Please review this PR which improves occurrences of lazy computation in > `Locale` and `BaseLocale`. > > Existing lazy initialization strategies such as CHM, static nested class, and > local inner class are replaced with Stable Values. > > L

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Johannes Döbler
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote: > Please review this PR which improves occurrences of lazy computation in > `Locale` and `BaseLocale`. > > Existing lazy initialization strategies such as CHM, static nested class, and > local inner class are replaced with Stable Values. > > L

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Per Minborg
On Thu, 5 Jun 2025 00:18:34 GMT, Chen Liang wrote: >> Please review this PR which improves occurrences of lazy computation in >> `Locale` and `BaseLocale`. >> >> Existing lazy initialization strategies such as CHM, static nested class, >> and local inner class are replaced with Stable Values.

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-05 Thread Andrey Turbanov
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote: > Please review this PR which improves occurrences of lazy computation in > `Locale` and `BaseLocale`. > > Existing lazy initialization strategies such as CHM, static nested class, and > local inner class are replaced with Stable Values. > > L

Re: RFR: 8358426: Improve lazy computation in Locale

2025-06-04 Thread Chen Liang
On Wed, 4 Jun 2025 21:20:46 GMT, Justin Lu wrote: > Please review this PR which improves occurrences of lazy computation in > `Locale` and `BaseLocale`. > > Existing lazy initialization strategies such as CHM, static nested class, and > local inner class are replaced with Stable Values. > > L

RFR: 8358426: Improve lazy computation in Locale

2025-06-04 Thread Justin Lu
Please review this PR which improves occurrences of lazy computation in `Locale` and `BaseLocale`. Existing lazy initialization strategies such as CHM, static nested class, and local inner class are replaced with Stable Values. Lambda usage is intentionally avoided in this change during `Locale