Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-04 Thread Stuart Marks
On Wed, 4 Jun 2025 16:50:15 GMT, Johannes Döbler wrote: >> Interesting. This `@NoOverride` idea could be useful on a subclass that >> wants to make sure it overrides everything. (Maybe `@NoInherit` would be a >> better name.) Meanwhile for JDK-8357272 (PR >> https://github.com/openjdk/jdk/pull

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-04 Thread Johannes Döbler
On Wed, 4 Jun 2025 16:19:23 GMT, Stuart Marks wrote: >> It would be helpful in situations like this to have the inverse annotation >> -- "All methods should be overridden, except the ones marked `@NoOverride`". > > Interesting. This `@NoOverride` idea could be useful on a subclass that wants >

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-04 Thread Stuart Marks
On Wed, 4 Jun 2025 04:08:36 GMT, Joe Darcy wrote: >> The `@Override` annotation has been inconsistently applied in the >> collections implementations. In practice since so many methods are >> overridden, and some test would likely fail if a method weren't overridden >> properly, the annotation

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-03 Thread Joe Darcy
On Tue, 3 Jun 2025 20:14:13 GMT, Stuart Marks wrote: >> src/java.base/share/classes/java/util/SequencedMap.java line 296: >> >>> 294: return view().hashCode(); >>> 295: } >>> 296: public void addFirst(K k) { throw new >>> UnsupportedOperationException();

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-03 Thread Stuart Marks
On Mon, 2 Jun 2025 20:41:41 GMT, Joe Darcy wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Tweak nsee() declaration; adjust specs per suggestion; update copyrights. > > src/java.base/share/classes/java/util/Sequenc

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-02 Thread Brent Christian
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote: >> For a full explanation, see the bug report >> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015). >> >> This PR includes three related changes: >> * New overrides in SequencedMap view collection implementations, which >> improve

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-06-02 Thread Joe Darcy
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote: >> For a full explanation, see the bug report >> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015). >> >> This PR includes three related changes: >> * New overrides in SequencedMap view collection implementations, which >> improve

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-05-31 Thread Jaikiran Pai
On Sat, 31 May 2025 00:47:16 GMT, Stuart Marks wrote: >> For a full explanation, see the bug report >> [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015). >> >> This PR includes three related changes: >> * New overrides in SequencedMap view collection implementations, which >> improve

Re: RFR: 8358015: Fix SequencedMap sequenced view method specifications [v2]

2025-05-30 Thread Stuart Marks
> For a full explanation, see the bug report > [JDK-8358015](https://bugs.openjdk.org/browse/JDK-8358015). > > This PR includes three related changes: > * New overrides in SequencedMap view collection implementations, which > improve their behavior. > * Update to `@implSpec` clauses to reflect t