On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
On Wed, 11 Jun 2025 11:41:41 GMT, David Beaumont wrote:
>> Christian Stein has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Extract shared function to compute current token
>
> test/jdk/tools/launcher/ArgFileSyntax.java line 177:
>
>> 17
On Wed, 11 Jun 2025 08:30:18 GMT, Christian Stein wrote:
>> Please review this fix to correctly parse tokens in an argument file that
>> contains trailing comments without preceding whitespace characters before
>> the '#' comment marker, the number sign.
>>
>> The specifaction of the `java` Co
On Tue, 10 Jun 2025 08:15:58 GMT, Christian Stein wrote:
>> Or the handling of `#` can be merged with the previous case ... somehow.
>
> Extracting a method wouldn't really simplify the code, as many local
> variables are in play.
>
> Merging the cases also ends up in more if-else constructs in
> Please review this fix to correctly parse tokens in an argument file that
> contains trailing comments without preceding whitespace characters before the
> '#' comment marker, the number sign.
>
> The specifaction of the `java` Command has in section [java Command-Line
> Argument
> Files](ht
