Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-15 Thread Raffaello Giulietti
On Tue, 13 May 2025 21:24:08 GMT, fabioromano1 wrote: >> Some changes in `Biginteger`s' bit operations that increase the code >> readability and slightly optimize the execution time. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-15 Thread fabioromano1
On Thu, 15 May 2025 13:51:29 GMT, Raffaello Giulietti wrote: > It cannot be made an instance method, though. There's one usage which needs a > static invocation. @rgiulietti If you are referring to [this invocation](https://github.com/fabioromano1/jdk/blob/5ad26a14049e1765d9ef46f307d723dd4b31

Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-15 Thread Raffaello Giulietti
On Tue, 13 May 2025 21:24:08 GMT, fabioromano1 wrote: >> Some changes in `Biginteger`s' bit operations that increase the code >> readability and slightly optimize the execution time. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-15 Thread fabioromano1
On Thu, 15 May 2025 13:35:29 GMT, Raffaello Giulietti wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update names > > Since you are at it, I'd suggest changing `javaIncrement` to be `static` (no > need to change

Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-15 Thread Raffaello Giulietti
On Tue, 13 May 2025 21:24:08 GMT, fabioromano1 wrote: >> Some changes in `Biginteger`s' bit operations that increase the code >> readability and slightly optimize the execution time. > > fabioromano1 has updated the pull request incrementally with one additional > commit since the last revision

Re: RFR: 8356891: Some code simplifications for basic BigIntegers' bit operations [v4]

2025-05-13 Thread fabioromano1
> Some changes in `Biginteger`s' bit operations that increase the code > readability and slightly optimize the execution time. fabioromano1 has updated the pull request incrementally with one additional commit since the last revision: Update names - Changes: - all: https://git