Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:47:02 GMT, Raffaello Giulietti wrote: >> _Really_ fails with Xmx7G > > Yes, the required heap size was not enough for the reverted variant to throw > a non-OOME exception/error. > > Just out of curiosity, is JDK-8356152 a real-world issue you stumbled upon, > or did you

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Raffaello Giulietti
On Mon, 5 May 2025 17:11:46 GMT, Andrey Turbanov wrote: >> test/jdk/java/lang/String/concat/HugeConcatTest.java line 38: >> >>> 36: import static org.junit.Assert.assertThrows; >>> 37: >>> 38: public class HugeConcatTest { >> >> I've tried to execute the test with reverting changes in >> `Str

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 14:38:05 GMT, Raffaello Giulietti wrote: >> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. > > Raffaello Giulietti has updated the pull request incrementally with one > additional commit since the last revision: > > Added language concat + to test. test/jdk/

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Andrey Turbanov
On Mon, 5 May 2025 17:09:37 GMT, Andrey Turbanov wrote: >> Raffaello Giulietti has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Added language concat + to test. > > test/jdk/java/lang/String/concat/HugeConcatTest.java line 38: > >> 36: i

Re: RFR: 8356152: String.concat can throw StringIndexOutOfBoundsException [v4]

2025-05-05 Thread Raffaello Giulietti
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23. Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision: Added language concat + to test. - Changes: - all: https://git.openjdk.org/jdk/pull/25038/files -