On Mon, 5 May 2025 20:58:56 GMT, Andrey Turbanov wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Increased min heap size to 8G.
>
> Marked as reviewed by aturbanov (Committer).
Thanks to the reviewers, and
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Increased min heap size to 8G.
Looks good,
On Tue, 6 May 2025 08:44:56 GMT, Raffaello Giulietti
wrote:
>> @ForceInline
>> static int checkOverflow(int value) {
>> if (value >= 0) {
>> return value;
>> }
>> throw new OutOfMemoryError("Overflow: String length out of range");
>> }
>>
>> priva
On Tue, 6 May 2025 08:22:51 GMT, Shaojin Wen wrote:
>> src/java.base/share/classes/java/lang/StringConcatHelper.java line 435:
>>
>>> 433: static String doConcat(String s1, String s2) {
>>> 434: byte coder = (byte) (s1.coder() | s2.coder());
>>> 435: int newLength = checkOver
On Tue, 6 May 2025 07:44:29 GMT, Claes Redestad wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Increased min heap size to 8G.
>
> src/java.base/share/classes/java/lang/StringConcatHelper.java line 435:
>
>
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Increased min heap size to 8G.
LGTM
src/j
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Increased min heap size to 8G.
Marked as r
On Mon, 5 May 2025 17:29:33 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Increased min heap size to 8G.
Test update
On Mon, 5 May 2025 17:47:02 GMT, Raffaello Giulietti
wrote:
>> _Really_ fails with Xmx7G
>
> Yes, the required heap size was not enough for the reverted variant to throw
> a non-OOME exception/error.
>
> Just out of curiosity, is JDK-8356152 a real-world issue you stumbled upon,
> or did you
On Mon, 5 May 2025 17:11:46 GMT, Andrey Turbanov wrote:
>> test/jdk/java/lang/String/concat/HugeConcatTest.java line 38:
>>
>>> 36: import static org.junit.Assert.assertThrows;
>>> 37:
>>> 38: public class HugeConcatTest {
>>
>> I've tried to execute the test with reverting changes in
>> `Str
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Increased min heap size to 8G.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25038/files
- ne
On Mon, 5 May 2025 14:38:05 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added language concat + to test.
test/jdk/
On Mon, 5 May 2025 17:09:37 GMT, Andrey Turbanov wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added language concat + to test.
>
> test/jdk/java/lang/String/concat/HugeConcatTest.java line 38:
>
>> 36: i
On Mon, 5 May 2025 14:23:11 GMT, Andrey Turbanov wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added '@requires' to test.
>
> test/jdk/java/lang/String/concat/HugeConcatTest.java line 38:
>
>> 36: import
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Added language concat + to test.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25038/files
-
On Mon, 5 May 2025 14:06:27 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Added '@requires' to test.
test/jdk/java/l
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Added '@requires' to test.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25038/files
- new: h
On Mon, 5 May 2025 13:51:13 GMT, Jaikiran Pai wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Simplified test slightly.
>
> test/jdk/java/lang/String/concat/HugeConcatTest.java line 29:
>
>> 27: * @summary
On Mon, 5 May 2025 13:36:05 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Simplified test slightly.
test/jdk/java/la
On Mon, 5 May 2025 13:36:05 GMT, Raffaello Giulietti
wrote:
>> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Simplified test slightly.
Looks good. So t
> A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Simplified test slightly.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/25038/files
- new: ht
A fix to throw `OutOfMemoryError`, as done in releases ≤ 23.
-
Commit messages:
- 8356152: String.concat can throw StringIndexOutOfBoundsException
Changes: https://git.openjdk.org/jdk/pull/25038/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25038&range=00
Issue: https:/
22 matches
Mail list logo
