On Thu, 8 May 2025 12:08:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8354799?
>
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero
> size was missing a CRC check for tha
On Thu, 8 May 2025 13:29:36 GMT, Alan Bateman wrote:
> > I'll run some experiments and see what it shows up.
>
> Thanks as that will help inform as to whether this will need a compatibility
> knob.
The crc is calculated as part of the write of the entry and I have not seen any
cases, where th
On Thu, 8 May 2025 12:08:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8354799?
>
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero
> size was missing a CRC check for tha
On Thu, 8 May 2025 13:10:57 GMT, Jaikiran Pai wrote:
> I'll run some experiments and see what it shows up.
Thanks as that will help inform as to whether this will need a compatibility
knob.
-
PR Comment: https://git.openjdk.org/jdk/pull/25116#issuecomment-2863078781
On Thu, 8 May 2025 13:01:38 GMT, Alan Bateman wrote:
> I'm just wondering if there are any wonky tools or plugins in the eco system,
> the output of which could be impacted by the more strict check.
I'll run some experiments and see what it shows up.
-
PR Comment: https://git.open
On Thu, 8 May 2025 12:08:09 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8354799?
>
> `java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero
> size was missing a CRC check for tha
Can I please get a review of this change which addresses the issue noted in
https://bugs.openjdk.org/browse/JDK-8354799?
`java.util.zip.ZipInputStream` when dealing with a `STORED` entry of zero size
was missing a CRC check for that entry. The change in this PR addresses that
and introduces a n
