Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v4]

2025-04-18 Thread Brian Burkhalter
On Thu, 17 Apr 2025 22:43:59 GMT, Roger Riggs wrote: > I'm fine with moving `readString` to `Reader`. Given that [Reader.read(char[])](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/io/Reader.html#read(char[])) exists, this should be a trivial change, implementation-wise. -

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v4]

2025-04-17 Thread Roger Riggs
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Change the test to reuse a ByteBuffer when wr

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v4]

2025-04-17 Thread Brian Burkhalter
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Change the test to reuse a ByteBuffer when wr

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v4]

2025-04-17 Thread Stuart Marks
On Thu, 17 Apr 2025 22:13:06 GMT, Brian Burkhalter wrote: >> Implement the requested methods and add a test thereof. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8354724: Change the test to reuse a ByteBuffer when wr

Re: RFR: 8354724: BufferedReader readAllLines and readString methods [v4]

2025-04-17 Thread Brian Burkhalter
> Implement the requested methods and add a test thereof. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8354724: Change the test to reuse a ByteBuffer when writing the file - Changes: - all: https://git.openjdk.o