On Sun, 4 May 2025 05:08:46 GMT, Alan Bateman wrote:
>> Oh, and we should set `next` afterwards, so the `Reader` knows that the end
>> of the sequence is reached:
>>
>>
>> public String readAllChars() throws IOException {
>> ensureOpen();
>> var len = cs.length();
>> var remainder
On Fri, 2 May 2025 19:38:11 GMT, Rémi Forax wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and
>> account for it in test
>
> test/jdk/java/io/Bu
On Thu, 1 May 2025 18:00:54 GMT, Stuart Marks wrote:
> I'd suggest not having this method's implementation depend on an overridable
> method.
I'm jumping the gun here by referring to an implementation detail, but the
overridable method problem could be circumvented using an approach taken in
On Fri, 2 May 2025 19:00:42 GMT, Stuart Marks wrote:
> I think it's still ambiguous. [...]
Without addressing the specific comments, I would simply like to point out that
"as if" and "equivalent" is common phrasing in this area, e.g.,
-
[File.toPath](https://docs.oracle.com/en/java/javase/24/
On Sat, 3 May 2025 09:30:17 GMT, Markus KARG wrote:
>> src/java.base/share/classes/java/io/Reader.java line 213:
>>
>>> 211: public String readAllChars() throws IOException {
>>> 212: ensureOpen();
>>> 213: return cs.toString().substring(next);
>>
>>
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Sat, 3 May 2025 07:25:09 GMT, Markus KARG wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and
>> account for it in test
>
> src/java.base/shar
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Fri, May 2, 2025 at 2:04 PM Stuart Marks wrote:
> There was a back-and-forth a while ago -- I think @bplb was involved --
> where there was similar wording about something being "equivalent to" or
> "as if" foo() was called, and the person was insistent that this meant that
> foo() should actu
On Thu, 1 May 2025 19:19:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/java/io/Reader.java line 408:
>>
>>> 406: * This method works as if invoking it were equivalent to
>>> evaluating
>>> 407: * the expression:
>>> 408: * {@linkplain
>>> #readAllChars()}.lines().to
On Thu, 1 May 2025 17:51:53 GMT, Stuart Marks wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8354724: Fix readAllChars gaffe in Reader returned by Readed.of and
>> account for it in test
>
> src/java.base/sha
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
On Wed, 23 Apr 2025 22:04:25 GMT, Brian Burkhalter wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8354724: Fix readAllChars gaffe in Reader returned by
> Implement the requested methods and add a test thereof.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8354724: Fix readAllChars gaffe in Reader returned by Readed.of and account
for it in test
-
Changes:
- all
18 matches
Mail list logo
