Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Vicente Romero
On Sat, 10 May 2025 16:03:37 GMT, Vicente Romero wrote: > > heh, I was doing the same, thanks anyway :) > > Awesome, thanks! > > Apologies for the mid-air collision :) I've merged your latest merge into my > merge, leaving just a few minor fixes. thanks! - PR Comment: https://gi

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Vicente Romero
On Sat, 10 May 2025 15:41:18 GMT, Archie Cobbs wrote: > > heh, I was doing the same, thanks anyway :) > > Awesome, thanks! > > Apologies for the mid-air collision :) I've merged your latest merge into my > merge, leaving just a few minor fixes. thanks! - PR Comment: https://git.

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Archie Cobbs
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote: > Thanks. Looks good, but the Lint to all option names streaming can be > replaced by the static map lookup/iteration. Good point... I prototyped that in commit be160a3261b. - PR Comment: https://git.openjdk.org/jdk/pull/24746#is

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Archie Cobbs
On Sat, 10 May 2025 15:35:16 GMT, Vicente Romero wrote: > heh, I was doing the same, thanks anyway :) Awesome, thanks! Apologies for the mid-air collision :) I've merged your latest merge into my merge, leaving just a few minor fixes. - PR Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Vicente Romero
On Sat, 10 May 2025 15:31:17 GMT, Chen Liang wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixing bugs, removing dead code > > Thanks. Looks good, but the Lint to all option names streaming can be > replaced b

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-10 Thread Chen Liang
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Vicente Romero
On Fri, 9 May 2025 20:43:46 GMT, Chen Liang wrote: >> Vicente Romero has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixing bugs, removing dead code > > make/langtools/src/classes/build/tools/symbolgenerator/CreateSymbols.java > line 22

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Chen Liang
On Fri, 9 May 2025 20:28:12 GMT, Vicente Romero wrote: >> This PR is defining a new internal annotation, >> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and >> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation >> that an argument to a given method or c

Re: RFR: 8354556: Expand value-based class warnings to java.lang.ref API [v9]

2025-05-09 Thread Vicente Romero
> This PR is defining a new internal annotation, > `@jdk.internal.RequiresIdentity`, with target types PARAMETER and > TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation > that an argument to a given method or constructor parameter will be an object > with a unique ident