On Sat, 10 May 2025 15:24:52 GMT, Archie Cobbs wrote:
>>> That's why I was offering my existing patch which basically does that
>>> already. But it's OK to wait if you prefer.
>>
>> Sure, I think vicente is open to patches and PRs to his fork. And I can help
>> review; just remember to @liach.
On Fri, 9 May 2025 22:39:19 GMT, Chen Liang wrote:
> Sure, I think vicente is open to patches and PRs to his fork. And I can help
> review; just remember to @liach.
OK thanks. I've rebased my changes on @vicente-romero-oracle's branch to simply
any evaluation. [Here's the
diff](https://github
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - addressing review comment
>> - changes to
On Fri, 9 May 2025 21:24:58 GMT, Archie Cobbs wrote:
> That's why I was offering my existing patch which basically does that
> already. But it's OK to wait if you prefer.
Sure, I think vicente is open to patches and PRs to his fork. And I can help
review; just remember to @liach.
On Fri, 9 May 2025 21:09:46 GMT, Chen Liang wrote:
> I think if we do that, we should encapsulate `option` and move all access,
> such as `option.isSet`, to dedicated methods on `LintCategory`. We are a bit
> short on time for this, so IMO our best approach is to open a followup issue
> that w
On Fri, 9 May 2025 21:06:09 GMT, Archie Cobbs wrote:
> Do we care about that? If so then we might want to implement a proper fix for
> lint aliases as a separate pre-requisite to this issue.
I think if we do that, we should encapsulate `option` and move all access, such
as `option.isSet`, to d
On Fri, 9 May 2025 20:25:40 GMT, Vicente Romero wrote:
> I was working on something in this line too, just pushed the patch
Looks reasonable, a couple of comments...
Can't `LintCategory.alias` be `final`? If so I think this obviates the patch to
`DetectMutableStaticFields.java`.
This is not a
On Thu, 8 May 2025 18:55:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge branch 'master' into JDK-8354556
>> - addressing review comment
>> - changes to
On Thu, 8 May 2025 13:33:45 GMT, Vicente Romero wrote:
>> This PR is defining a new internal annotation,
>> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
>> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
>> that an argument to a given method or c
> This PR is defining a new internal annotation,
> `@jdk.internal.RequiresIdentity`, with target types PARAMETER and
> TYPE_PARAMETER. The @RequiresIdentity annotation expresses the expectation
> that an argument to a given method or constructor parameter will be an object
> with a unique ident
10 matches
Mail list logo
