Re: RFR: 8353888: Implement Key Derivation Function API [v3]

2025-04-09 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: update @since tags as required by JEP 12 - Changes: - all: https://git.openjdk.org/jdk/pull/24520/files - new: https://git.openjdk.org/jdk/pull/2

Re: RFR: 8353888: Implement Key Derivation Function API [v2]

2025-04-08 Thread Alan Bateman
On Tue, 8 Apr 2025 21:03:18 GMT, Chen Liang wrote: >> Oh, I didn't know that. I've built this with JDK 24 as the boot JDK and see >> no problem. > > I think the dependency is in the CreateSymbols tool or something Yes, we've had issues with boot cycle builds at least, Jan has the details and I

Re: RFR: 8353888: Implement Key Derivation Function API [v2]

2025-04-08 Thread Weijun Wang
> Finalize the KDF API. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: add enum back - Changes: - all: https://git.openjdk.org/jdk/pull/24520/files - new: https://git.openjdk.org/jdk/pull/24520/files/4ff3b95b..66706a

Re: RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 21:00:41 GMT, Weijun Wang wrote: >> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: >> >>> 80: MODULE_IMPORTS, >>> 81: @JEP(number=478, title="Key Derivation Function API", >>> status="Preview") >>> 82: KEY_DERIVATION, >> >

Re: RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Weijun Wang
On Tue, 8 Apr 2025 19:35:33 GMT, Chen Liang wrote: >> Finalize the KDF API. > > src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > >> 80: MODULE_IMPORTS, >> 81: @JEP(number=478, title="Key Derivation Function API", >> status="Preview") >> 82: K

Re: RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Chen Liang
On Tue, 8 Apr 2025 18:14:53 GMT, Weijun Wang wrote: > Finalize the KDF API. Changes requested by liach (Reviewer). src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82: > 80: MODULE_IMPORTS, > 81: @JEP(number=478, title="Key Derivation Function API", > st

RFR: 8353888: Implement Key Derivation Function API

2025-04-08 Thread Weijun Wang
Finalize the KDF API. - Commit messages: - the change Changes: https://git.openjdk.org/jdk/pull/24520/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24520&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353888 Stats: 42 lines in 16 files changed: 0 ins; 30 del; 12