On Mon, 7 Apr 2025 13:35:57 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
On Thu, 10 Apr 2025 09:03:36 GMT, Alan Bateman wrote:
>> It's very odd, but when I attempt this then the resource is not found. It
>> seems to fail on the module name verification. For example: `jlink --help |
>> tail -n2` shows as `disabled` for an enabled linkable runtime image.
>
> Without r
On Tue, 8 Apr 2025 13:31:10 GMT, Severin Gehwolf wrote:
>> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java
>> line 71:
>>
>>> 69: private static InputStream getDiffInputStream(String module) throws
>>> IOException {
>>> 70: String resourceName = Strin
On Wed, 9 Apr 2025 11:42:31 GMT, Magnus Ihse Bursie wrote:
>> Sure. It's not really a properties file (which assumes `key=value`). How
>> about `upgrade_files_.conf`? Then the pattern could be
>> `upgrade_files_*.conf`. Thoughts?
>
> Yeah, my comment was meant more like "maybe you should turn i
On Wed, 9 Apr 2025 11:38:25 GMT, Severin Gehwolf wrote:
>> make/modules/jdk.jlink/Java.gmk line 28:
>>
>>> 26:
>>>
>>> 27:
>>> 28: COPY += upgrade_files_java.base
>>
>> Any chance you can give this file a differe
On Wed, 9 Apr 2025 10:36:03 GMT, Magnus Ihse Bursie wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review v2
>
> make/modules/jdk.jlink/Java.gmk line 28:
>
>> 26:
>> ##
On Mon, 7 Apr 2025 13:35:57 GMT, Severin Gehwolf wrote:
>> For JEP 493-enabled builds there are no JMODs. Certain files come from the
>> installed JDK image when a user creates a custom run-time from it. This is
>> problematic for example for files that often come from a different package
>> (
On Mon, 7 Apr 2025 17:30:53 GMT, Alan Bateman wrote:
>> Severin Gehwolf has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review v2
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/LinkableRuntimeImage.java
> line 71:
>
>> 69:
> For JEP 493-enabled builds there are no JMODs. Certain files come from the
> installed JDK image when a user creates a custom run-time from it. This is
> problematic for example for files that often come from a different package
> (e.g. `cacerts` file for Linux distro builds of OpenJDK package
