Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v6]

2025-05-21 Thread duke
On Wed, 21 May 2025 06:54:37 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > address review comments @pawanchawdhary1 Your cha

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v6]

2025-05-21 Thread Mikhailo Seledtsov
On Wed, 21 May 2025 06:54:37 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > address review comments Thanks for the updates. Ch

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v6]

2025-05-21 Thread Leonid Mesnik
On Wed, 21 May 2025 06:54:37 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > address review comments Thanks for fixing this! -

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v6]

2025-05-21 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: address review comments - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files - new: https://

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v5]

2025-05-20 Thread PAWAN CHAWDHARY
On Thu, 15 May 2025 16:21:56 GMT, Leonid Mesnik wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove unused import > > test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java line 73: > >> 71:

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v5]

2025-05-15 Thread Leonid Mesnik
On Thu, 15 May 2025 10:03:11 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused import Changes requested by lmesnik

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v5]

2025-05-15 Thread Mikhailo Seledtsov
On Thu, 15 May 2025 10:03:11 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Remove unused import Marked as reviewed by mseledt

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-15 Thread PAWAN CHAWDHARY
On Wed, 14 May 2025 09:41:58 GMT, Sergey Chernyshev wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v5]

2025-05-15 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: Remove unused import - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files - new: https://git

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-15 Thread PAWAN CHAWDHARY
On Tue, 13 May 2025 14:46:00 GMT, Ivan Bereziuk wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > The change looks good. There might be some issues with container engine

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v4]

2025-05-15 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: Remove unused method getDockerVersionStr - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Mikhailo Seledtsov
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code Overall cha

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Sergey Chernyshev
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code test/hotspo

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-14 Thread Sergey Chernyshev
On Tue, 13 May 2025 14:46:00 GMT, Ivan Bereziuk wrote: > I wrote 2 comments. but cold not post them. They are in "pending" state. Not > sure why. Should the comments be first reviewed by {Committers|Reviewers}? please go to `Files changed` panel and press Review Changes -> Submit review --

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-13 Thread Ivan Bereziuk
On Fri, 2 May 2025 10:00:07 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > Refactor container runtime version code The change

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v2]

2025-05-02 Thread PAWAN CHAWDHARY
On Tue, 29 Apr 2025 20:28:36 GMT, Sergey Chernyshev wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update reference of DockerVersion > > test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetricsSubgroup.ja

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-02 Thread PAWAN CHAWDHARY
On Tue, 29 Apr 2025 20:18:17 GMT, Sergey Chernyshev wrote: >> PAWAN CHAWDHARY has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Refactor container runtime version code > > test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v3]

2025-05-02 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: Refactor container runtime version code - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v2]

2025-04-29 Thread Sergey Chernyshev
On Tue, 29 Apr 2025 14:45:25 GMT, PAWAN CHAWDHARY wrote: >> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails > > PAWAN CHAWDHARY has updated the pull request incrementally with one > additional commit since the last revision: > > update reference of DockerVersion test/hotspot/jtr

Re: RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v2]

2025-04-29 Thread PAWAN CHAWDHARY
> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision: update reference of DockerVersion - Changes: - all: https://git.openjdk.org/jdk/pull/24948/files - new

RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails

2025-04-29 Thread PAWAN CHAWDHARY
8352926: New test TestDockerMemoryMetricsSubgroup.java fails - Commit messages: - update comment - 8352926: New test TestDockerMemoryMetricsSubgroup.java fails Changes: https://git.openjdk.org/jdk/pull/24948/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24948&range=00