On Tue, 1 Apr 2025 16:12:39 GMT, Alan Bateman wrote:
> > @AlanBateman Any more thoughts on this? We'd need to include a patch like
> > this one for getting the Fedora JDK 24+ builds to work with JEP 493
> > enabled. Thanks!
>
> Allowing for a small number of upgradable files is needed, I see y
On Wed, 26 Mar 2025 10:12:43 GMT, Alan Bateman wrote:
> > The cacerts issue mentioned in the JBS issue relates to an RPM installation
> > of the JDK where the cacerts file is a symlink to the distro provided one.
> > So I think that's "use system" issue.
> > TZ updates would potentially break t
On Wed, 26 Mar 2025 17:43:50 GMT, Christoph Langer wrote:
> Would it maybe make sense/be possible to offer some re-hash functionality for
> using in 2nd step builds?
What would that be? Right now linking from the run-time image doesn't allow for
`jdk.jlink` to be included, which prevents a 2nd
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
>>> > The cacerts issue mentioned in the JBS issue relates to an RPM
>>> > installation of the JDK where the cacerts file is a symlink to the distro
>>> > provided one. So I think that's "use system" issue.
>>> > TZ updates would potentially
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
>>> > The cacerts issue mentioned in the JBS issue relates to an RPM
>>> > installation of the JDK where the cacerts file is a symlink to the distro
>>> > provided one. So I think that's "use system" issue.
>>> > TZ updates would potentially
On Wed, 26 Mar 2025 17:09:06 GMT, Severin Gehwolf wrote:
>> Please review this enhancement which adds a hidden `jlink` option
>> `--sha-overrides` that can be used to provide alternative hash sums for
>> files in an image. Please see the bug for use-cases as to why this is
>> needed. This patc
On Wed, 26 Mar 2025 13:42:11 GMT, Severin Gehwolf wrote:
>> test/jdk/tools/jlink/runtimeImage/ModifiedFilesWithShaOverrideTest.java line
>> 32:
>>
>>> 30: * @requires (vm.compMode != "Xcomp" & os.maxMemory >= 2g & os.family
>>> == "linux")
>>> 31: * @library ../../lib /test/lib
>>> 32: * @e
On Wed, 26 Mar 2025 08:28:23 GMT, Christoph Langer wrote:
>> Severin Gehwolf has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Copyright updates
>> - Allow for ${java.home} substitution when \@file is being passed
>>
>>Also refa
> Please review this enhancement which adds a hidden `jlink` option
> `--sha-overrides` that can be used to provide alternative hash sums for files
> in an image. Please see the bug for use-cases as to why this is needed. This
> patch allows for the `--sha-overrides` option to be either specifie
On Wed, 26 Mar 2025 17:47:07 GMT, Severin Gehwolf wrote:
> > Would it maybe make sense/be possible to offer some re-hash functionality
> > for using in 2nd step builds?
>
> What would that be? Right now linking from the run-time image doesn't allow
> for `jdk.jlink` to be included, which preve
On Wed, 26 Mar 2025 14:50:11 GMT, Alan Bateman wrote:
> > I'll keep looking into this specific case. However, it sounds a bit
> > orthogonal to the patch at hand which I do believe we still need for the
> > original reasons mentioned (RPM changing binaries after the JDK build is
> > long done
On Wed, 26 Mar 2025 14:42:12 GMT, Severin Gehwolf wrote:
> I'll keep looking into this specific case. However, it sounds a bit
> orthogonal to the patch at hand which I do believe we still need for the
> original reasons mentioned (RPM changing binaries after the JDK build is long
> done and t
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote:
>> Please review this enhancement which adds a hidden `jlink` option
>> `--sha-overrides` that can be used to provide alternative hash sums for
>> files in an image. Please see the bug for use-cases as to why this is
>> needed. This patc
On Wed, 26 Mar 2025 09:53:51 GMT, Severin Gehwolf wrote:
> The cacerts issue mentioned in the JBS issue relates to an RPM installation
> of the JDK where the cacerts file is a symlink to the distro provided one. So
> I think that's "use system" issue.
>
> TZ updates would potentially break thi
On Wed, 26 Mar 2025 08:53:21 GMT, Alan Bateman wrote:
> > @AlanBateman Would we need a CSR for this? This isn't any option that shows
> > up anywhere user-visible, so I'm thinking not. Please let me know. Thanks!
>
> There isn't any change to a supported interface so probably not.
Thanks.
> T
On Tue, 25 Mar 2025 17:54:43 GMT, Severin Gehwolf wrote:
> @AlanBateman Would we need a CSR for this? This isn't any option that shows
> up anywhere user-visible, so I'm thinking not. Please let me know. Thanks!
There isn't any change to a supported interface so probably not. That said, I
don'
> Please review this enhancement which adds a hidden `jlink` option
> `--sha-overrides` that can be used to provide alternative hash sums for files
> in an image. Please see the bug for use-cases as to why this is needed. This
> patch allows for the `--sha-overrides` option to be either specifie
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote:
>> Please review this enhancement which adds a hidden `jlink` option
>> `--sha-overrides` that can be used to provide alternative hash sums for
>> files in an image. Please see the bug for use-cases as to why this is
>> needed. This patc
On Tue, 25 Mar 2025 17:43:07 GMT, Severin Gehwolf wrote:
>> Please review this enhancement which adds a hidden `jlink` option
>> `--sha-overrides` that can be used to provide alternative hash sums for
>> files in an image. Please see the bug for use-cases as to why this is
>> needed. This patc
On Tue, 25 Mar 2025 13:51:10 GMT, Christoph Langer wrote:
> The only review thing I could find were the copyright years which need
> updates.
I've fixed copyright years in the latest update.
-
PR Comment: https://git.openjdk.org/jdk/pull/24190#issuecomment-2752051896
On Mon, 24 Mar 2025 11:02:15 GMT, Severin Gehwolf wrote:
> Please review this enhancement which adds a hidden `jlink` option
> `--sha-overrides` that can be used to provide alternative hash sums for files
> in an image. Please see the bug for use-cases as to why this is needed. This
> patch al
Please review this enhancement which adds a hidden `jlink` option
`--sha-overrides` that can be used to provide alternative hash sums for files
in an image. Please see the bug for use-cases as to why this is needed. This
patch allows for the `--sha-overrides` option to be either specified multip
22 matches
Mail list logo
