Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-04-22 Thread KIRIYAMA Takuya
On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote: >> The current test program for the logging feature added in JDK-8301627 does >> not fully check some important cases. >> >> Issue Details: >> The test does not properly check cases where logging might not happen due to >> different logging

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-05 Thread Jaikiran Pai
On Fri, 21 Mar 2025 09:05:27 GMT, KIRIYAMA Takuya wrote: >> The current test program for the logging feature added in JDK-8301627 does >> not fully check some important cases. >> >> Issue Details: >> The test does not properly check cases where logging might not happen due to >> different logg

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-04-05 Thread Mikhail Yankelevich
On Fri, 14 Mar 2025 09:17:06 GMT, KIRIYAMA Takuya wrote: > The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging le

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-05 Thread KIRIYAMA Takuya
On Wed, 19 Mar 2025 20:09:51 GMT, Roger Riggs wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java > > test/jdk/java/lang/RuntimeTests/ExitLogging-FINER

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-04 Thread Mikhail Yankelevich
On Fri, 21 Mar 2025 09:01:01 GMT, KIRIYAMA Takuya wrote: >> test/jdk/java/lang/RuntimeTests/RuntimeExitLogTest.java line 52: >> >>> 50: private static final String TEST_JDK = >>> System.getProperty("test.jdk"); >>> 51: private static final String TEST_SRC = >>> System.getProperty("test

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-04 Thread KIRIYAMA Takuya
> The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging levels. (e.g. ALL, TRACE, WARNING, etc.) > The check for the

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v3]

2025-04-04 Thread KIRIYAMA Takuya
On Tue, 25 Mar 2025 18:39:22 GMT, Roger Riggs wrote: >> I see. This test only takes a very short time, but shouldn't the cases be >> added? > > Still no, starting a new Java runtime isn't that quick, and it brings no > additional value. > All tests are run 10's of thousands of times in every re

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-04-04 Thread KIRIYAMA Takuya
On Wed, 26 Mar 2025 16:24:20 GMT, Jaikiran Pai wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java > > test/jdk/java/lang/RuntimeTests/RuntimeExitLogTe

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v3]

2025-04-04 Thread KIRIYAMA Takuya
> The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging levels. (e.g. ALL, TRACE, WARNING, etc.) > The check for the

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-03-25 Thread Roger Riggs
On Fri, 21 Mar 2025 09:06:14 GMT, KIRIYAMA Takuya wrote: >> test/jdk/java/lang/RuntimeTests/ExitLogging-FINER.properties line 8: >> >>> 6: >>> 7: java.util.logging.ConsoleHandler.level = ALL >>> 8: java.lang.Runtime.level = FINER >> >> It is a waste of resources to test every combination of lo

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-03-21 Thread KIRIYAMA Takuya
On Wed, 19 Mar 2025 19:54:41 GMT, Roger Riggs wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java > > test/jdk/java/lang/RuntimeTests/ExitLogging-FINE.

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-03-21 Thread KIRIYAMA Takuya
On Wed, 19 Mar 2025 20:07:26 GMT, Roger Riggs wrote: > Out of curiosity, what raised this as an issue that needed more tests? Was > there a failure of some implementation that caused a bug? Thank you for your comment. No, I haven't found any bugs yet. This is an important feature that is often

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java [v2]

2025-03-21 Thread KIRIYAMA Takuya
On Tue, 18 Mar 2025 12:34:37 GMT, Mikhail Yankelevich wrote: >> KIRIYAMA Takuya has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java > > test/jdk/java/lang/RuntimeTests/RuntimeE

Re: RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-03-19 Thread Roger Riggs
On Fri, 14 Mar 2025 09:17:06 GMT, KIRIYAMA Takuya wrote: > The current test program for the logging feature added in JDK-8301627 does > not fully check some important cases. > > Issue Details: > The test does not properly check cases where logging might not happen due to > different logging le

RFR: 8352016: Improve java/lang/RuntimeTests/RuntimeExitLogTest.java

2025-03-16 Thread KIRIYAMA Takuya
The current test program for the logging feature added in JDK-8301627 does not fully check some important cases. Issue Details: The test does not properly check cases where logging might not happen due to different logging levels. (e.g. ALL, TRACE, WARNING, etc.) The check for the logged stack t