> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Revert accidental file change.
-
Changes:
- all: https://gi
On Mon, 24 Mar 2025 13:56:21 GMT, Chen Liang wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert accidental file change.
>
> Looks good, these locations in the JDK 24 docs indeed have extra braces
> (besides Ab
On Mon, 24 Mar 2025 13:29:24 GMT, Archie Cobbs wrote:
>> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
>> braces have been sneaking in.
>
> Archie Cobbs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert a
On Mon, 24 Mar 2025 05:23:58 GMT, Chen Liang wrote:
> Shouldn't this closing `)` be wrapped in `{@code}` like `{@code )}` to match
> with the code format in `{@code (getLocale()}`?
Yes it should - thanks. The two rows above also have the same problem, i.e., I
was just making this row consisten
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Apply font fixes per review suggestion.
-
Changes:
- all: h
On Thu, 13 Mar 2025 01:57:20 GMT, Archie Cobbs wrote:
>> src/java.base/share/classes/java/text/MessageFormat.java line 327:
>>
>>> 325: * {@code unit}
>>> 326: * {@link ListFormat#getInstance(Locale, ListFormat.Type,
>>> ListFormat.Style)
>>> 327: * ListFormat.getInstance}{
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
LGTM
-
PR Review: https://git.openjdk.org/jdk/pull/24022#pullrequestreview-2681298904
On Thu, 13 Mar 2025 01:46:53 GMT, Iris Clark wrote:
> Where's the matching `(`? I'm guessing that the IDE thinks it's the one
> immediately before the `getLocale()`, but I suspect that javadoc won't agree
> with that.
You are correct - the matching `(` is the one preceding `getLocale()`.
I'm
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
src/java.base/share/classes/java/text/MessageFormat.java line 327:
> 325: * {@code unit}
> 326: * {@link ListFormat#
On Thu, 13 Mar 2025 01:21:54 GMT, Archie Cobbs wrote:
> This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
> braces have been sneaking in.
The change in `MessageFormat.java` looks good
-
PR Review: https://git.openjdk.org/jdk/pull/24022#pullrequestreview-2
This PR fixes minor Javadoc typos in a few `java.base` classes. Extra curly
braces have been sneaking in.
-
Commit messages:
- Fix minor Javadoc typos.
Changes: https://git.openjdk.org/jdk/pull/24022/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24022&range=00
Issue: h
11 matches
Mail list logo
