Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v8]

2025-06-05 Thread Erik Gahlin
On Thu, 5 Jun 2025 09:51:51 GMT, Alan Bateman wrote: >> Erik Gahlin has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove the mistakenly added file. >> - Fix whitespace > > src/jdk.jfr/share/conf/jfr/default.jfc line 845: > >> 843:

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v8]

2025-06-05 Thread Alan Bateman
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote: >> Could I have review of an enhancement that adds rate-limited sampling to >> Java events, including five events in the JDK (SocketRead, SocketWrite, >> FileRead, FileWrite, and JavaExceptionThrow). >> >> Testing: test/jdk/jdk/jfr >> >> Tha

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v8]

2025-06-05 Thread Alan Bateman
On Thu, 5 Jun 2025 09:41:10 GMT, Erik Gahlin wrote: >> Could I have review of an enhancement that adds rate-limited sampling to >> Java events, including five events in the JDK (SocketRead, SocketWrite, >> FileRead, FileWrite, and JavaExceptionThrow). >> >> Testing: test/jdk/jdk/jfr >> >> Tha

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v8]

2025-06-05 Thread Alan Bateman
On Thu, 5 Jun 2025 09:37:45 GMT, Erik Gahlin wrote: >> Could I have review of an enhancement that adds rate-limited sampling to >> Java events, including five events in the JDK (SocketRead, SocketWrite, >> FileRead, FileWrite, and JavaExceptionThrow). >> >> Testing: test/jdk/jdk/jfr >> >> Tha

Re: RFR: 8351594: JFR: Rate-limited sampling of Java events [v8]

2025-06-05 Thread Erik Gahlin
> Could I have review of an enhancement that adds rate-limited sampling to Java > events, including five events in the JDK (SocketRead, SocketWrite, FileRead, > FileWrite, and JavaExceptionThrow). > > Testing: test/jdk/jdk/jfr > > Thanks > Erik Erik Gahlin has updated the pull request incremen