Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll [v2]

2025-03-11 Thread Henry Jen
> JDK-8349989: jlink can use String.replace instead of String.replaceAll Henry Jen has updated the pull request incrementally with one additional commit since the last revision: Address review feedbacks - Changes: - all: https://git.openjdk.org/jdk/pull/23954/files - new: htt

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll [v3]

2025-03-11 Thread Alan Bateman
On Tue, 11 Mar 2025 16:27:52 GMT, Henry Jen wrote: >> JDK-8349989: jlink can use String.replace instead of String.replaceAll > > Henry Jen has updated the pull request incrementally with one additional > commit since the last revision: > > Update copyright year Marked as reviewed by alanb (R

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-11 Thread Henry Jen
On Sun, 9 Mar 2025 18:11:07 GMT, Chen Liang wrote: >> src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794: >> >>> 792: log.format("%-40s %s%n", >>> 793:"-".repeat(internalApiTitle.length()), >>> 794:

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll [v3]

2025-03-11 Thread Henry Jen
> JDK-8349989: jlink can use String.replace instead of String.replaceAll Henry Jen has updated the pull request incrementally with one additional commit since the last revision: Update copyright year - Changes: - all: https://git.openjdk.org/jdk/pull/23954/files - new: https:

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll [v2]

2025-03-11 Thread Alan Bateman
On Mon, 10 Mar 2025 22:08:06 GMT, Henry Jen wrote: >> JDK-8349989: jlink can use String.replace instead of String.replaceAll > > Henry Jen has updated the pull request incrementally with one additional > commit since the last revision: > > Address review feedbacks I think this looks okay, I

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-09 Thread Chen Liang
On Sun, 9 Mar 2025 14:38:45 GMT, Alan Bateman wrote: >> JDK-8349989: jlink can use String.replace instead of String.replaceAll > > src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794: > >> 792: log.format("%-40s %s%n", >> 793:

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-09 Thread Chen Liang
On Sat, 8 Mar 2025 00:28:15 GMT, Henry Jen wrote: > JDK-8349989: jlink can use String.replace instead of String.replaceAll src/jdk.jlink/share/classes/jdk/tools/jlink/internal/ImageResourcesTree.java line 303: > 301: } > 302: String pkg = removeRadical(path, module + "/

Re: RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-09 Thread Alan Bateman
On Sat, 8 Mar 2025 00:28:15 GMT, Henry Jen wrote: > JDK-8349989: jlink can use String.replace instead of String.replaceAll src/jdk.jdeps/share/classes/com/sun/tools/jdeps/JdepsTask.java line 794: > 792: log.format("%-40s %s%n", > 793:"-".repea

RFR: 8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll

2025-03-07 Thread Henry Jen
JDK-8349989: jlink can use String.replace instead of String.replaceAll - Commit messages: - JDK-8349989: jlink can use String.replace instead of String.replaceAll - JDK-8349984: (jdeps) jdeps can use String.repeat instead of String.replaceAll Changes: https://git.openjdk.org/jdk/pu