Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

On Thu, 20 Feb 2025 17:32:06 GMT, Joe Wang wrote: >> Hi all, >> >> Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes >> unexpectedly when missing the depentdent file >> test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a >> NULL check after call

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd [v2]

On Fri, 21 Feb 2025 01:38:34 GMT, SendaoYan wrote: >> Hi all, >> >> Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes >> unexpectedly when missing the depentdent file >> test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a >> NULL check after cal

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

On Thu, 20 Feb 2025 17:32:06 GMT, Joe Wang wrote: > Yes, that would do. Thanks, PR has been updated. - PR Comment: https://git.openjdk.org/jdk/pull/23627#issuecomment-2673138446

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd [v2]

> Hi all, > > Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes > unexpectedly when missing the depentdent file > test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a > NULL check after call `getResourceAsStream("CR6740048.xsd")`. > > This PR do n

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

On Fri, 14 Feb 2025 07:44:26 GMT, SendaoYan wrote: > Hi all, > > Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes > unexpectedly when missing the depentdent file > test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a > NULL check after call `get

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

On Wed, 19 Feb 2025 20:04:33 GMT, Joe Wang wrote: > The schema file is integral to the test, so we assume it will be present. A > minor improvement would be to remove the conditional check that verifies its > existence. This would allow the test to fail if it can't load the schema file. Do you

Re: RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

On Fri, 14 Feb 2025 07:44:26 GMT, SendaoYan wrote: > Hi all, > > Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes > unexpectedly when missing the depentdent file > test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a > NULL check after call `get

RFR: 8349959: Test CR6740048.java passes unexpectedly missing CR6740048.xsd

Hi all, Test test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.java run passes unexpectedly when missing the depentdent file test/jaxp/javax/xml/jaxp/unittest/validation/CR6740048.xsd. This PR add a NULL check after call `getResourceAsStream("CR6740048.xsd")`. This PR do not change the or