On Fri, 7 Feb 2025 20:05:49 GMT, Naoto Sato wrote:
>> This is a follow-on fix to
>> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java
>> launcher can take arguments from "JDK_JAVA_OPTIONS" environment variable, so
>> the same processing is needed. Also, obsolete code for Win
On Fri, 7 Feb 2025 20:05:49 GMT, Naoto Sato wrote:
>> This is a follow-on fix to
>> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java
>> launcher can take arguments from "JDK_JAVA_OPTIONS" environment variable, so
>> the same processing is needed. Also, obsolete code for Win
On Fri, 7 Feb 2025 18:39:25 GMT, Naoto Sato wrote:
>> src/java.base/share/native/libjli/args.c line 472:
>>
>>> 470: JLI_AddArgsFromEnvVar(JLI_List args, const char *var_name) {
>>> 471: #ifdef _WIN32
>>> 472: char *env = winGetEnv(var_name);
>>
>> I see that we are limiting this call to us
On Fri, 7 Feb 2025 20:11:06 GMT, Naoto Sato wrote:
>> src/java.base/share/native/libjli/args.c line 611:
>>
>>> 609: LPWSTR wcVarName = JLI_MemAlloc(wcCount * sizeof(wchar_t));
>>> 610: if (MultiByteToWideChar(CP_ACP, 0, var_name, -1, wcVarName,
>>> wcCount) != 0) {
>>> 611:
On Fri, 7 Feb 2025 20:05:49 GMT, Naoto Sato wrote:
>> This is a follow-on fix to
>> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java
>> launcher can take arguments from "JDK_JAVA_OPTIONS" environment variable, so
>> the same processing is needed. Also, obsolete code for Win
On Fri, 7 Feb 2025 18:53:40 GMT, Justin Lu wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review
>
> src/java.base/share/native/libjli/args.c line 603:
>
>> 601: /*
>> 602: * getenv() without best-fit map
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows 9x has been removed.
Naoto Sato has updated the pul
On Fri, 7 Feb 2025 18:32:26 GMT, Naoto Sato wrote:
>> This is a follow-on fix to
>> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java
>> launcher can take arguments from "JDK_JAVA_OPTIONS" environment variable, so
>> the same processing is needed. Also, obsolete code for Win
On Fri, 7 Feb 2025 14:42:44 GMT, Jaikiran Pai wrote:
> In (the Windows specific) `src/java.base/windows/native/libjli/cmdtoargs.c`
> there's an additional call to lookup (a different) `_JAVA_OPTIONS`
> environment variable through `getenv()` just to log out that environment
> variable's value.
On Fri, 7 Feb 2025 13:41:03 GMT, Jaikiran Pai wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review
>
> src/java.base/share/native/libjli/args.c line 472:
>
>> 470: JLI_AddArgsFromEnvVar(JLI_List args, con
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows 9x has been removed.
Naoto Sato has updated the pul
On Thu, 6 Feb 2025 19:46:21 GMT, Naoto Sato wrote:
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows
On Thu, 6 Feb 2025 19:46:21 GMT, Naoto Sato wrote:
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows
On Thu, 6 Feb 2025 19:46:21 GMT, Naoto Sato wrote:
> This is a follow-on fix to
> [JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
> can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
> processing is needed. Also, obsolete code for Windows
This is a follow-on fix to
[JDK-8337506](https://bugs.openjdk.org/browse/JDK-8337506). The Java launcher
can take arguments from "JDK_JAVA_OPTIONS" environment variable, so the same
processing is needed. Also, obsolete code for Windows 9x has been removed.
-
Commit messages:
- ini
15 matches
Mail list logo
