Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 18:02:57 GMT, Chen Liang wrote: >> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains eight commits: >> >> - Merge remote-tracking branch 'upstream/master' into >> allocate_un_init_202501 >> >>

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-02 Thread Chen Liang
On Fri, 2 May 2025 03:55:24 GMT, Shaojin Wen wrote: >> The byte[] allocated in Integer/Long.toString is fully filled, so we can use >> StringConcatHelper::newArray to create byte[] to improve performance. > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-02 Thread Shaojin Wen
On Fri, 2 May 2025 17:35:38 GMT, Roger Riggs wrote: > The StringConcatHelper methods should not be used outside of StringConcat. I had a version that used UNSAFE.allocateUninitializedArray , but @liach suggested using StringConcatHelper.newArray - PR Comment: https://git.openjdk.o

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-02 Thread Roger Riggs
On Fri, 2 May 2025 03:55:24 GMT, Shaojin Wen wrote: >> The byte[] allocated in Integer/Long.toString is fully filled, so we can use >> StringConcatHelper::newArray to create byte[] to improve performance. > > Shaojin Wen has updated the pull request with a new target base due to a > merge or a

Re: RFR: 8349176: Speed up Integer/Long.toString via StringConcatHelper::newArray [v3]

2025-05-01 Thread Shaojin Wen
> The byte[] allocated in Integer/Long.toString is fully filled, so we can use > StringConcatHelper::newArray to create byte[] to improve performance. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merg