On Tue, 28 Jan 2025 20:07:17 GMT, Kevin Rushforth wrote:
> A Mach5 job I submitted passed
@kevinrushforth Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/23340#issuecomment-2619970106
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 20:08:54 GMT, Alexey Semenyuk wrote:
> I believe it complained about the way DEF_STATIC_JNI_OnLoad is defined. That
> is why disabling the usage of DEF_STATIC_JNI_OnLoad fixes the problem.
That probably describes the issue more clear. Thumbs up.
-
PR Comment: h
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:54:21 GMT, Alexey Semenyuk wrote:
> > zip_util.c(94): error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
>
> It doesn't look like it complains about undefined DEF_STATIC_JNI_OnLoad
The compilation error I saw did.
A Mach5 job I submitted passed in one case where
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> zip_util.c(94): error C2054: expected '(' to follow 'DEF_STATIC_JNI_OnLoad'
It doesn't look like it complains about undefined DEF_STATIC_JNI_OnLoad
-
PR Comment: https://git.openjdk.org/jdk/pull/23340#issuecomment-2619931580
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
On Tue, 28 Jan 2025 19:22:52 GMT, Jiangli Zhou wrote:
> Please review this workaround for the compiler error on Windows. This error
> occurs in closed build with custom make logic that uses zip_util.c. The error
> indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
> Wi
Please review this workaround for the compiler error on Windows. This error
occurs in closed build with custom make logic that uses zip_util.c. The error
indicates `DEF_STATIC_JNI_OnLoad` is not defined, thus disable the macro on
Windows for now until the cause is fully understood.
[2025-01-28
11 matches
Mail list logo
