Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread David Holmes
On Thu, 16 Jan 2025 17:53:48 GMT, Leonid Mesnik wrote: >> test/lib/jdk/test/lib/hprof/parser/ReadBuffer.java line 46: >> >>> 44: public int getInt(long pos) throws IOException; >>> 45: public long getLong(long pos) throws IOException; >>> 46: public void close() throws IOExceptio

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread David Holmes
On Thu, 16 Jan 2025 18:18:15 GMT, Leonid Mesnik wrote: >> There few compiler warning disabled in the testlibary build. >> They should be fixed or localized and removed from build to prevent new >> possible issues. >> >> The main goal is to avoid new such issues in the testlibrary. >> Tested wi

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 18:14:39 GMT, Leonid Mesnik wrote: >> There few compiler warning disabled in the testlibary build. >> They should be fixed or localized and removed from build to prevent new >> possible issues. >> >> The main goal is to avoid new such issues in the testlibrary. >> Tested wi

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 07:09:46 GMT, Alan Bateman wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert change > > test/lib/jdk/test/lib/thread/VThreadPinner.java line 97: > >> 95: * virtual thread then it inv

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
On Thu, 16 Jan 2025 05:31:44 GMT, David Holmes wrote: >> Leonid Mesnik has updated the pull request incrementally with one additional >> commit since the last revision: >> >> revert change > > test/lib/jdk/test/lib/format/ArrayDiff.java line 110: > >> 108: * @return an ArrayDiff instanc

Re: RFR: 8347840: Fix testlibrary compilation warnings [v3]

2025-01-16 Thread Leonid Mesnik
> There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tier1-5 to ensure that all tests were passed. Leonid Mesnik

Re: RFR: 8347840: Fix testlibrary compilation warnings [v2]

2025-01-16 Thread Leonid Mesnik
> There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tier1-5 to ensure that all tests were passed. Leonid Mesnik

Re: RFR: 8347840: Fix testlibrary compilation warnings

2025-01-15 Thread Alan Bateman
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote: > There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tie

Re: RFR: 8347840: Fix testlibrary compilation warnings

2025-01-15 Thread David Holmes
On Wed, 15 Jan 2025 23:48:33 GMT, Leonid Mesnik wrote: > There few compiler warning disabled in the testlibary build. > They should be fixed or localized and removed from build to prevent new > possible issues. > > The main goal is to avoid new such issues in the testlibrary. > Tested with tie

RFR: 8347840: Fix testlibrary compilation warnings

2025-01-15 Thread Leonid Mesnik
There few compiler warning disabled in the testlibary build. They should be fixed or localized and removed from build to prevent new possible issues. The main goal is to avoid new such issues in the testlibrary. Tested with tier1-5 to ensure that all tests were passed. - Commit mes