Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-29 Thread Chen Liang
On Tue, 29 Apr 2025 18:40:51 GMT, ExE Boss wrote: >> Hmm, I intentionally avoided implementing spliterator because there are too >> many opportunities to optimize - a fully optimized Spliterator implementaton >> should split an int mask. Can we do that in another patch? I need to check >> if M

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-29 Thread ExE Boss
On Sun, 27 Apr 2025 17:29:32 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 722: >> >>> 720: } >>> 721: >>> 722: private static final class AccessFlagSet extends >>> AbstractSet { >> >> This should probably also define the spliterator meth

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-28 Thread Chen Liang
On Mon, 28 Apr 2025 19:56:23 GMT, Roger Riggs wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix iterator missing NSEE > > src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 634: > >> 632:

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-28 Thread Roger Riggs
On Sat, 26 Apr 2025 19:44:02 GMT, Chen Liang wrote: >> Some AccessFlag parsing methods throw IAE because a flag mask is not valid >> in a location. However, there is no easy way to check what flag mask bits or >> what flags are valid for a location. We need such APIs to check, specific to >> e

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-27 Thread Chen Liang
On Sun, 27 Apr 2025 16:47:59 GMT, ExE Boss wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix iterator missing NSEE > > src/java.base/share/classes/java/lang/reflect/AccessFlag.java line 722: > >> 720: } >> 721

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-27 Thread ExE Boss
On Sat, 26 Apr 2025 19:44:02 GMT, Chen Liang wrote: >> Some AccessFlag parsing methods throw IAE because a flag mask is not valid >> in a location. However, there is no easy way to check what flag mask bits or >> what flags are valid for a location. We need such APIs to check, specific to >> e

Re: RFR: 8347471: Provide valid flags and mask in AccessFlag.Location [v8]

2025-04-26 Thread Chen Liang
> Some AccessFlag parsing methods throw IAE because a flag mask is not valid in > a location. However, there is no easy way to check what flag mask bits or > what flags are valid for a location. We need such APIs to check, specific to > each class file format version. > > Also in the investigat