Re: [jdk24] RFR: 8345773: Class-File API debug printing capability

2024-12-12 Thread Adam Sotona
On Wed, 11 Dec 2024 08:06:19 GMT, Adam Sotona wrote: > Class-File API lost debug printing capability with removal of the > j.l.classfile.components.ClassPrinter in JDK-8345343. > > This is a backport of > https://github.com/openjdk/jdk/commit/f88c1c6ff86b8f29a71647e46136b6432bb67619, > review

Re: [jdk24] RFR: 8345773: Class-File API debug printing capability

2024-12-11 Thread Chen Liang
On Wed, 11 Dec 2024 08:06:19 GMT, Adam Sotona wrote: > Class-File API lost debug printing capability with removal of the > j.l.classfile.components.ClassPrinter in JDK-8345343. > > This is a backport of > https://github.com/openjdk/jdk/commit/f88c1c6ff86b8f29a71647e46136b6432bb67619, > review

[jdk24] RFR: 8345773: Class-File API debug printing capability

2024-12-11 Thread Adam Sotona
8345773: Class-File API debug printing capability - Commit messages: - Backport f88c1c6ff86b8f29a71647e46136b6432bb67619 Changes: https://git.openjdk.org/jdk/pull/22675/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22675&range=00 Issue: https://bugs.openjdk.org/browse/J

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-11 Thread Adam Sotona
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-10 Thread Chen Liang
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-09 Thread Maurizio Cimadamore
On Mon, 9 Dec 2024 18:09:21 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-09 Thread Chen Liang
On Mon, 9 Dec 2024 18:06:16 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v4]

2024-12-09 Thread Adam Sotona
> Class-File API lost debug printing capability with removal of the > `j.l.classfile.components.ClassPrinter` in JDK-8345343. > This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore > the capability. > > Please review. > > Thank you, > Adam Adam Sotona has updated the p

Re: RFR: 8345773: Class-File API debug printing capability [v3]

2024-12-09 Thread Maurizio Cimadamore
On Mon, 9 Dec 2024 16:01:21 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v3]

2024-12-09 Thread Chen Liang
On Mon, 9 Dec 2024 15:58:01 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v3]

2024-12-09 Thread Adam Sotona
> Class-File API lost debug printing capability with removal of the > `j.l.classfile.components.ClassPrinter` in JDK-8345343. > This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore > the capability. > > Please review. > > Thank you, > Adam Adam Sotona has updated the p

Re: RFR: 8345773: Class-File API debug printing capability [v2]

2024-12-09 Thread Chen Liang
On Mon, 9 Dec 2024 14:23:07 GMT, Eirik Bjørsnøs wrote: > Just to be abundantly clear, should the API description state that the exact > format of the debug string is unspecified and subject to change? I thought the word "debug" already conveys that. You should leave this comment in CSR review

Re: RFR: 8345773: Class-File API debug printing capability [v2]

2024-12-09 Thread Eirik Bjørsnøs
On Mon, 9 Dec 2024 12:59:24 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v2]

2024-12-09 Thread Chen Liang
On Mon, 9 Dec 2024 12:59:24 GMT, Adam Sotona wrote: >> Class-File API lost debug printing capability with removal of the >> `j.l.classfile.components.ClassPrinter` in JDK-8345343. >> This PR adds `j.l.classfile.CompoundElement::toDebugString` method to >> restore the capability. >> >> Please r

Re: RFR: 8345773: Class-File API debug printing capability [v2]

2024-12-09 Thread Adam Sotona
> Class-File API lost debug printing capability with removal of the > `j.l.classfile.components.ClassPrinter` in JDK-8345343. > This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore > the capability. > > Please review. > > Thank you, > Adam Adam Sotona has updated the p

RFR: 8345773: Class-File API debug printing capability

2024-12-09 Thread Adam Sotona
Class-File API lost debug printing capability with removal of the `j.l.classfile.components.ClassPrinter` in JDK-8345343. This PR adds `j.l.classfile.CompoundElement::toDebugString` method to restore the capability. Please review. Thank you, Adam - Commit messages: - unused impor