Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes [v2]

2025-01-24 Thread Eirik Bjørsnøs
On Fri, 17 Jan 2025 18:19:56 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which adds the `final` modifier to non-subclassable >> classes in `java.base`. >> >> The classes were identified using an automated analysis. See CSR for details. >> >> Besides simply adding the `final` access mod

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes [v2]

2025-01-17 Thread Weijun Wang
On Fri, 17 Jan 2025 18:19:56 GMT, Eirik Bjørsnøs wrote: >> Please review this PR which adds the `final` modifier to non-subclassable >> classes in `java.base`. >> >> The classes were identified using an automated analysis. See CSR for details. >> >> Besides simply adding the `final` access mod

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes [v2]

2025-01-17 Thread Eirik Bjørsnøs
> Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier, the PR: > > * Updates a note in `java.lang.constant.Dyna

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-17 Thread Sean Mullan
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier,

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-17 Thread Daniel Jeliński
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier,

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
On Tue, 26 Nov 2024 20:08:28 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/net/InterfaceAddress.java line 45: >> >>> 43: >>> 44: /* >>> 45: * Package private constructor. Can't be built directly, instances >>> are >> >> The comment is outdated. This constructor is actua

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier,

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Chen Liang
On Tue, 26 Nov 2024 20:03:39 GMT, Chen Liang wrote: >> Please review this PR which adds the `final` modifier to non-subclassable >> classes in `java.base`. >> >> The classes were identified using an automated analysis. See CSR for details. >> >> Besides simply adding the `final` access modifie

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
On Tue, 26 Nov 2024 18:55:50 GMT, Eirik Bjørsnøs wrote: >> src/java.base/share/classes/java/lang/module/ModuleDescriptor.java line 1318: >> >>> 1316: Version version, >>> 1317: Set modifiers, >>> 1318: Set requires, >> >> I assume y

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Chen Liang
On Tue, 26 Nov 2024 19:08:26 GMT, Eirik Bjørsnøs wrote: >> Thanks! Yes, that's good feedback. There are some non-API changes that I'd >> like to make, such as this and updating the comment for the >> `InterfaceAddress` constructor. >> >> I prefered to make the initial PR draft contain just the

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
On Tue, 26 Nov 2024 18:00:21 GMT, Chen Liang wrote: >> Please review this PR which adds the `final` modifier to non-subclassable >> classes in `java.base`. >> >> The classes were identified using an automated analysis. See CSR for details. >> >> Besides simply adding the `final` access modifie

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Alan Bateman
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier,

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Chen Liang
On Tue, 26 Nov 2024 13:04:41 GMT, Eirik Bjørsnøs wrote: > Please review this PR which adds the `final` modifier to non-subclassable > classes in `java.base`. > > The classes were identified using an automated analysis. See CSR for details. > > Besides simply adding the `final` access modifier,

RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
Please review this PR which adds the `final` modifier to non-subclassable classes in `java.base`. The classes were identified using an automated analysis. See CSR for details. Besides simply adding the `final` access modifier, the PR: * Updates a note in `java.lang.constant.DynamicCallSiteDesc`

Re: RFR: 8344943: Mark not subclassable classes final in java.base exported classes

2025-01-16 Thread Eirik Bjørsnøs
On Tue, 26 Nov 2024 18:49:07 GMT, Alan Bateman wrote: >> Please review this PR which adds the `final` modifier to non-subclassable >> classes in `java.base`. >> >> The classes were identified using an automated analysis. See CSR for details. >> >> Besides simply adding the `final` access modif