Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop [v2]

2024-11-21 Thread Alexander Zvegintsev
On Fri, 22 Nov 2024 00:01:32 GMT, Phil Race wrote: >> Clean up permission checks in java.awt.Desktop class >> Also remove no longer needed exports from java.base to java.desktop > > Phil Race has updated the pull request incrementally with one additional > commit since the last revision: > >

Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop

2024-11-21 Thread Alexander Zvegintsev
On Thu, 21 Nov 2024 23:58:05 GMT, Phil Race wrote: > Did you mean to mention that in this PR ? Not sure how it came up here. Yes, I saw that the `sun.security.action` is no longer exported to `java.desktop`, and just wanted to check that it is no longer used in there(even in comments). --

Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop [v2]

2024-11-21 Thread Phil Race
> Clean up permission checks in java.awt.Desktop class > Also remove no longer needed exports from java.base to java.desktop Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8344799 - Changes: - all: https://git.openjdk.or

Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop

2024-11-21 Thread Phil Race
On Thu, 21 Nov 2024 23:46:14 GMT, Alexander Zvegintsev wrote: > There is a mention of the `GetPropertyAction` left in the comment: > > https://github.com/openjdk/jdk/blob/c199f5326b8dd41f33a12e5db7552331e0844601/src/java.desktop/share/classes/sun/awt/util/PerformanceLogger.java#L130 Did you me

Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop

2024-11-21 Thread Alexander Zvegintsev
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote: > Clean up permission checks in java.awt.Desktop class > Also remove no longer needed exports from java.base to java.desktop There is a mention of the `GetPropertyAction` left in the comment: https://github.com/openjdk/jdk/blob/c199f5326b8dd41f

Re: RFR: 8344799: Remove permissions checks from java.awt.Desktop

2024-11-21 Thread Alexander Zvegintsev
On Thu, 21 Nov 2024 22:21:47 GMT, Phil Race wrote: > Clean up permission checks in java.awt.Desktop class > Also remove no longer needed exports from java.base to java.desktop Marked as reviewed by azvegint (Reviewer). src/java.desktop/share/classes/java/awt/Desktop.java line 409: > 407:

RFR: 8344799: Remove permissions checks from java.awt.Desktop

2024-11-21 Thread Phil Race
Clean up permission checks in java.awt.Desktop class Also remove no longer needed exports from java.base to java.desktop - Commit messages: - 8344799 Changes: https://git.openjdk.org/jdk/pull/22311/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22311&range=00 Issue: http